Description
Tomás Cohen Arazi (tcohen)
2025-07-29 13:45:37 UTC
Created attachment 184810 [details] [review] Bug 40542: Add cancellation_reason to Koha::Hold->strings_map This patch adds the mentioned AV to the returned strings structure. It also adds tests for the method. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Created attachment 184811 [details] [review] Bug 40542: Add strings embed to holds-related endpoints This patch makes holds endpoints be allowed to embed strings. To test: 1. Use your favourite REST tool to hit /api/v1/holds 2. Add the `x-koha-embed: +strings` header. => FAIL: The API rejects because it is not equiped with the feature. 3. Apply this patches 4. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: It works! 6. Sign off :-D Created attachment 184836 [details] [review] Bug 40542: Add cancellation_reason to Koha::Hold->strings_map This patch adds the mentioned AV to the returned strings structure. It also adds tests for the method. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Created attachment 184837 [details] [review] Bug 40542: Add strings embed to holds-related endpoints This patch makes holds endpoints be allowed to embed strings. To test: 1. Use your favourite REST tool to hit /api/v1/holds 2. Add the `x-koha-embed: +strings` header. => FAIL: The API rejects because it is not equiped with the feature. 3. Apply this patches 4. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: It works! 6. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Created attachment 184881 [details] [review] Bug 40542: Add cancellation_reason to Koha::Hold->strings_map This patch adds the mentioned AV to the returned strings structure. It also adds tests for the method. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 184882 [details] [review] Bug 40542: Add strings embed to holds-related endpoints This patch makes holds endpoints be allowed to embed strings. To test: 1. Use your favourite REST tool to hit /api/v1/holds 2. Add the `x-koha-embed: +strings` header. => FAIL: The API rejects because it is not equiped with the feature. 3. Apply this patches 4. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: It works! 6. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to main for 25.11 This is causing KohaTable/PendingHolds_spec.ts tests to fail. Created attachment 185074 [details] [review] Bug 40542: (40174 follow-up) Skip _strings for object creation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Follow-up pushed to main |