Bug 33568 introduced the `Koha::Hold->strings_map` method which is only used for embedding srings in the biblios endpoint. The holds-related endpoint themselves don't use it. We should add `+strings` for using it in bug 40530.
Created attachment 184810 [details] [review] Bug 40542: Add cancellation_reason to Koha::Hold->strings_map This patch adds the mentioned AV to the returned strings structure. It also adds tests for the method. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D
Created attachment 184811 [details] [review] Bug 40542: Add strings embed to holds-related endpoints This patch makes holds endpoints be allowed to embed strings. To test: 1. Use your favourite REST tool to hit /api/v1/holds 2. Add the `x-koha-embed: +strings` header. => FAIL: The API rejects because it is not equiped with the feature. 3. Apply this patches 4. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: It works! 6. Sign off :-D
Created attachment 184836 [details] [review] Bug 40542: Add cancellation_reason to Koha::Hold->strings_map This patch adds the mentioned AV to the returned strings structure. It also adds tests for the method. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com>
Created attachment 184837 [details] [review] Bug 40542: Add strings embed to holds-related endpoints This patch makes holds endpoints be allowed to embed strings. To test: 1. Use your favourite REST tool to hit /api/v1/holds 2. Add the `x-koha-embed: +strings` header. => FAIL: The API rejects because it is not equiped with the feature. 3. Apply this patches 4. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: It works! 6. Sign off :-D Signed-off-by: David Nind <david@davidnind.com>
Created attachment 184881 [details] [review] Bug 40542: Add cancellation_reason to Koha::Hold->strings_map This patch adds the mentioned AV to the returned strings structure. It also adds tests for the method. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 184882 [details] [review] Bug 40542: Add strings embed to holds-related endpoints This patch makes holds endpoints be allowed to embed strings. To test: 1. Use your favourite REST tool to hit /api/v1/holds 2. Add the `x-koha-embed: +strings` header. => FAIL: The API rejects because it is not equiped with the feature. 3. Apply this patches 4. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: It works! 6. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11