| Summary: | pickup_library.branchname embed wrong | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Status: | Pushed to oldstable --- | QA Contact: | Jonathan Druart <jonathan.druart> | 
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart, lucas, nick, tomascohen | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | 25.11.00,25.05.04,24.11.10 | Circulation function: | |
| Bug Depends on: | 35560, 40530 | ||
| Bug Blocks: | |||
| Attachments: | Bug 40543: Remove pickup_library.branchname embed Bug 40543: Remove pickup_library.branchname embed Bug 40543: Remove pickup_library.branchname embed Bug 40543: Remove pickup_library.branchname embed Bug 40543: Remove pickup_library.branchname embed | ||
| 
        
          Description
        
        
          Tomás Cohen Arazi (tcohen)
        
        
        
        
          2025-07-29 14:31:32 UTC
        
       Created attachment 184815 [details] [review] Bug 40543: Remove pickup_library.branchname embed This patch removes this wrongly added embed and adjusts the patron holds history to use `pickup_location.name` instead. To test: 1. Have a patron with some past holds from different branches 2. Browse their holds history 3. Search on the 'Library' column by name => SUCCESS: It works :-D 4. Apply the patch 5. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 6. Repeat 2-3 => SUCCESS: Still works! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I'm getting a "sha1 information is lacking or useless/fake ancestor" error when I try to apply th epatch 8-(.. Applying: Bug 40543: Remove pickup_library.branchname embed error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt). error: could not build fake ancestor Patch failed at 0001 Bug 40543: Remove pickup_library.branchname embed (In reply to David Nind from comment #2) > I'm getting a "sha1 information is lacking or useless/fake ancestor" error > when I try to apply th epatch 8-(.. Yeah, I forgot 40530 was a dependency. Please retry :-D Created attachment 184849 [details] [review] Bug 40543: Remove pickup_library.branchname embed This patch removes this wrongly added embed and adjusts the patron holds history to use `pickup_location.name` instead. To test: 1. Have a patron with some past holds from different branches 2. Browse their holds history 3. Search on the 'Library' column by name => SUCCESS: It works :-D 4. Apply the patch 5. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 6. Repeat 2-3 => SUCCESS: Still works! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> (In reply to Tomás Cohen Arazi (tcohen) from comment #3) > (In reply to David Nind from comment #2) > > I'm getting a "sha1 information is lacking or useless/fake ancestor" error > > when I try to apply th epatch 8-(.. > > Yeah, I forgot 40530 was a dependency. Please retry :-D Thanks! Now signed off. Created attachment 184883 [details] [review] Bug 40543: Remove pickup_library.branchname embed This patch removes this wrongly added embed and adjusts the patron holds history to use `pickup_location.name` instead. To test: 1. Have a patron with some past holds from different branches 2. Browse their holds history 3. Search on the 'Library' column by name => SUCCESS: It works :-D 4. Apply the patch 5. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 6. Repeat 2-3 => SUCCESS: Still works! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 185254 [details] [review] Bug 40543: Remove pickup_library.branchname embed This patch removes this wrongly added embed and adjusts the patron holds history to use `pickup_location.name` instead. To test: 1. Have a patron with some past holds from different branches 2. Browse their holds history 3. Search on the 'Library' column by name => SUCCESS: It works :-D 4. Apply the patch 5. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 6. Repeat 2-3 => SUCCESS: Still works! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 185428 [details] [review] Bug 40543: Remove pickup_library.branchname embed This patch removes this wrongly added embed and adjusts the patron holds history to use `pickup_location.name` instead. To test: 1. Have a patron with some past holds from different branches 2. Browse their holds history 3. Search on the 'Library' column by name => SUCCESS: It works :-D 4. Apply the patch 5. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 6. Repeat 2-3 => SUCCESS: Still works! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.10 |