Bug 40543 - pickup_library.branchname embed wrong
Summary: pickup_library.branchname embed wrong
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 35560 40530
Blocks:
  Show dependency treegraph
 
Reported: 2025-07-29 14:31 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-07-31 18:28 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40543: Remove pickup_library.branchname embed (2.52 KB, patch)
2025-07-29 14:42 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40543: Remove pickup_library.branchname embed (2.56 KB, patch)
2025-07-30 02:50 UTC, David Nind
Details | Diff | Splinter Review
Bug 40543: Remove pickup_library.branchname embed (2.64 KB, patch)
2025-07-30 12:27 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-07-29 14:31:32 UTC
I'm not sure how that slipped in, but we need to clear it.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-07-29 14:42:26 UTC
Created attachment 184815 [details] [review]
Bug 40543: Remove pickup_library.branchname embed

This patch removes this wrongly added embed and adjusts the patron holds
history to use `pickup_location.name` instead.

To test:
1. Have a patron with some past holds from different branches
2. Browse their holds history
3. Search on the 'Library' column by name
=> SUCCESS: It works :-D
4. Apply the patch
5. Run:
   $ ktd --shell
  k$ yarn api:bundle
  k$ koha-plack --restart kohadev
6. Repeat 2-3
=> SUCCESS: Still works!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2025-07-29 18:34:34 UTC
I'm getting a "sha1 information is lacking or useless/fake ancestor" error when I try to apply th epatch 8-(..


Applying: Bug 40543: Remove pickup_library.branchname embed
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 40543: Remove pickup_library.branchname embed
Comment 3 Tomás Cohen Arazi (tcohen) 2025-07-29 20:24:05 UTC
(In reply to David Nind from comment #2)
> I'm getting a "sha1 information is lacking or useless/fake ancestor" error
> when I try to apply th epatch 8-(..

Yeah, I forgot 40530 was a dependency. Please retry :-D
Comment 4 David Nind 2025-07-30 02:50:47 UTC
Created attachment 184849 [details] [review]
Bug 40543: Remove pickup_library.branchname embed

This patch removes this wrongly added embed and adjusts the patron holds
history to use `pickup_location.name` instead.

To test:
1. Have a patron with some past holds from different branches
2. Browse their holds history
3. Search on the 'Library' column by name
=> SUCCESS: It works :-D
4. Apply the patch
5. Run:
   $ ktd --shell
  k$ yarn api:bundle
  k$ koha-plack --restart kohadev
6. Repeat 2-3
=> SUCCESS: Still works!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-07-30 02:51:36 UTC
(In reply to Tomás Cohen Arazi (tcohen) from comment #3)
> (In reply to David Nind from comment #2)
> > I'm getting a "sha1 information is lacking or useless/fake ancestor" error
> > when I try to apply th epatch 8-(..
> 
> Yeah, I forgot 40530 was a dependency. Please retry :-D

Thanks! Now signed off.
Comment 6 Jonathan Druart 2025-07-30 12:27:54 UTC
Created attachment 184883 [details] [review]
Bug 40543: Remove pickup_library.branchname embed

This patch removes this wrongly added embed and adjusts the patron holds
history to use `pickup_location.name` instead.

To test:
1. Have a patron with some past holds from different branches
2. Browse their holds history
3. Search on the 'Library' column by name
=> SUCCESS: It works :-D
4. Apply the patch
5. Run:
   $ ktd --shell
  k$ yarn api:bundle
  k$ koha-plack --restart kohadev
6. Repeat 2-3
=> SUCCESS: Still works!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>