Bug 40592

Summary: Fix incorrect row highlighting on patron checkout history page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to stable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: m.de.rooy
Version: MainKeywords: regression
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.04
Circulation function:
Bug Depends on: 38783    
Bug Blocks:    
Attachments: Bug 40592: Fix incorrect row highlighting on patron checkout history page
Bug 40592: Fix incorrect row highlighting on patron checkout history page
Bug 40592: Fix incorrect row highlighting on patron checkout history page

Description Owen Leonard 2025-08-04 19:00:42 UTC
At some point in the rebasing of Bug 38714 a regression happened with members/readingrec.tt

https://gitlab.com/koha-community/Koha/-/commit/c0961118625b2d398fba5bbf09601fbc99b28646

The <tr> should not have any classes added.
Comment 1 Owen Leonard 2025-08-04 19:12:35 UTC
Created attachment 185113 [details] [review]
Bug 40592: Fix incorrect row highlighting on patron checkout history page

To test:
1. Check out some items to a patron so they have a circulation history,
   the check in some of those items..
2. Look at the patron's "Circulation history" table. There are four
   possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0,
   and #FFFFCC.
3. Apply the patch and reload the page.
4. An orange/gold badge will appear under the "Return date" column of
   the table for items that have been checked out, and there will no
   longer be alternating, pale yellow rows.

Sponsored-by: Athens County Public Libraries
Comment 2 Caroline Cyr La Rose 2025-08-04 19:47:21 UTC
Created attachment 185114 [details] [review]
Bug 40592: Fix incorrect row highlighting on patron checkout history page

To test:
1. Check out some items to a patron so they have a circulation history,
   the check in some of those items..
2. Look at the patron's "Circulation history" table. There are four
   possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0,
   and #FFFFCC.
3. Apply the patch and reload the page.
4. An orange/gold badge will appear under the "Return date" column of
   the table for items that have been checked out, and there will no
   longer be alternating, pale yellow rows.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Marcel de Rooy 2025-08-08 09:23:11 UTC
Created attachment 185263 [details] [review]
Bug 40592: Fix incorrect row highlighting on patron checkout history page

To test:
1. Check out some items to a patron so they have a circulation history,
   the check in some of those items..
2. Look at the patron's "Circulation history" table. There are four
   possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0,
   and #FFFFCC.
3. Apply the patch and reload the page.
4. An orange/gold badge will appear under the "Return date" column of
   the table for items that have been checked out, and there will no
   longer be alternating, pale yellow rows.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Lucas Gass (lukeg) 2025-08-13 19:41:43 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-09-20 08:58:51 UTC
Nice work everyone!

Pushed to 25.05.x