Bug 40592 - Fix incorrect row highlighting on patron checkout history page
Summary: Fix incorrect row highlighting on patron checkout history page
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: regression
Depends on: 38783
Blocks:
  Show dependency treegraph
 
Reported: 2025-08-04 19:00 UTC by Owen Leonard
Modified: 2025-08-04 19:47 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40592: Fix incorrect row highlighting on patron checkout history page (1.67 KB, patch)
2025-08-04 19:12 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40592: Fix incorrect row highlighting on patron checkout history page (1.74 KB, patch)
2025-08-04 19:47 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-08-04 19:00:42 UTC
At some point in the rebasing of Bug 38714 a regression happened with members/readingrec.tt

https://gitlab.com/koha-community/Koha/-/commit/c0961118625b2d398fba5bbf09601fbc99b28646

The <tr> should not have any classes added.
Comment 1 Owen Leonard 2025-08-04 19:12:35 UTC
Created attachment 185113 [details] [review]
Bug 40592: Fix incorrect row highlighting on patron checkout history page

To test:
1. Check out some items to a patron so they have a circulation history,
   the check in some of those items..
2. Look at the patron's "Circulation history" table. There are four
   possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0,
   and #FFFFCC.
3. Apply the patch and reload the page.
4. An orange/gold badge will appear under the "Return date" column of
   the table for items that have been checked out, and there will no
   longer be alternating, pale yellow rows.

Sponsored-by: Athens County Public Libraries
Comment 2 Caroline Cyr La Rose 2025-08-04 19:47:21 UTC
Created attachment 185114 [details] [review]
Bug 40592: Fix incorrect row highlighting on patron checkout history page

To test:
1. Check out some items to a patron so they have a circulation history,
   the check in some of those items..
2. Look at the patron's "Circulation history" table. There are four
   possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0,
   and #FFFFCC.
3. Apply the patch and reload the page.
4. An orange/gold badge will appear under the "Return date" column of
   the table for items that have been checked out, and there will no
   longer be alternating, pale yellow rows.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>