Bug 40600

Summary: Typo in ILL requests template: "Complete request request"
Product: Koha Reporter: Anneli Österman <anneli.osterman>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Passed QA --- QA Contact: Laura Escamilla <Laura.escamilla>
Severity: normal    
Priority: P5 - low CC: flaterdavid, Laura.escamilla
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 40600: Fix typo in ILL request template
Bug 40600: Fix typo in ILL request template

Description Anneli Österman 2025-08-06 10:19:23 UTC
Is there a typo in sentence "Complete request request %s"? Should there be the word 'request' only once?

https://translate.koha-community.org/translate/koha/main/staff-prog/fi/?checksum=eb7a0f4321173f15

https://gitlab.com/koha-community/koha/-/blob/main/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt#L49
Comment 1 Owen Leonard 2025-08-07 16:59:34 UTC
Created attachment 185235 [details] [review]
Bug 40600: Fix typo in ILL request template

This patch fixes a typo in the staff interface's ILL request template,
removing an extra word.

I'm not sure how to test the patch via the interface. It looks like
'mark_completed' action doesn't involve a confirmation step, so the
relevant case in the breadcrumbs menu logic doesn't ever get triggered.

However, examining the patch should be sufficient for QA.

Sponsored-by: Athens County Public Libraries
Comment 2 Laura Escamilla 2025-08-16 00:07:30 UTC
Created attachment 185487 [details] [review]
Bug 40600: Fix typo in ILL request template

This patch fixes a typo in the staff interface's ILL request template,
removing an extra word.

I'm not sure how to test the patch via the interface. It looks like
'mark_completed' action doesn't involve a confirmation step, so the
relevant case in the breadcrumbs menu logic doesn't ever get triggered.

However, examining the patch should be sufficient for QA.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>