Bug 40600 - Typo in ILL requests template: "Complete request request"
Summary: Typo in ILL requests template: "Complete request request"
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-06 10:19 UTC by Anneli Österman
Modified: 2025-09-20 08:58 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.04
Circulation function:


Attachments
Bug 40600: Fix typo in ILL request template (1.63 KB, patch)
2025-08-07 16:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40600: Fix typo in ILL request template (1.70 KB, patch)
2025-08-16 00:07 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Anneli Österman 2025-08-06 10:19:23 UTC
Is there a typo in sentence "Complete request request %s"? Should there be the word 'request' only once?

https://translate.koha-community.org/translate/koha/main/staff-prog/fi/?checksum=eb7a0f4321173f15

https://gitlab.com/koha-community/koha/-/blob/main/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt#L49
Comment 1 Owen Leonard 2025-08-07 16:59:34 UTC
Created attachment 185235 [details] [review]
Bug 40600: Fix typo in ILL request template

This patch fixes a typo in the staff interface's ILL request template,
removing an extra word.

I'm not sure how to test the patch via the interface. It looks like
'mark_completed' action doesn't involve a confirmation step, so the
relevant case in the breadcrumbs menu logic doesn't ever get triggered.

However, examining the patch should be sufficient for QA.

Sponsored-by: Athens County Public Libraries
Comment 2 Laura Escamilla 2025-08-16 00:07:30 UTC
Created attachment 185487 [details] [review]
Bug 40600: Fix typo in ILL request template

This patch fixes a typo in the staff interface's ILL request template,
removing an extra word.

I'm not sure how to test the patch via the interface. It looks like
'mark_completed' action doesn't involve a confirmation step, so the
relevant case in the breadcrumbs menu logic doesn't ever get triggered.

However, examining the patch should be sufficient for QA.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 3 Lucas Gass (lukeg) 2025-08-20 18:57:17 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 4 Paul Derscheid 2025-09-20 08:58:53 UTC
Nice work everyone!

Pushed to 25.05.x