Bug 40604

Summary: Rename system preference OPACDisableSendList
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: dcook, gmcharlt
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 39374    
Bug Blocks:    

Description Fridolin Somers 2025-08-06 14:05:42 UTC
System preference "OPACDisableSendList" is using :
  1: "Don't allow"
  0: Allow

It works but is disturbing to have a double negative usage :
  [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( ! Koha.Preference('OPACDisableSendList') ) %]

I propose to rename "OPACAllowSendList" with :
  0: "Don't allow"
  1: Allow
Comment 1 David Cook 2025-08-06 23:49:14 UTC
I think that you're right. Looking at syspref names, I think this is the only one that starts with "OPACDisable" while there are a number with "OpacAllow" or "OPACAllow". 

The original intention here was to make it easily backwards compatible.

In Koha, the default is to allow OPAC send list, so if you did rename the syspref to "OPACAllowSendList" where 0 is "Don't allow" and 1 is "Allow", you'll have to remember to do a database update to flip all the values for "OPACAllowSendList".