Bug 40604 - Rename system preference OPACDisableSendList
Summary: Rename system preference OPACDisableSendList
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 39374
Blocks:
  Show dependency treegraph
 
Reported: 2025-08-06 14:05 UTC by Fridolin Somers
Modified: 2025-08-06 23:49 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2025-08-06 14:05:42 UTC
System preference "OPACDisableSendList" is using :
  1: "Don't allow"
  0: Allow

It works but is disturbing to have a double negative usage :
  [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( ! Koha.Preference('OPACDisableSendList') ) %]

I propose to rename "OPACAllowSendList" with :
  0: "Don't allow"
  1: Allow
Comment 1 David Cook 2025-08-06 23:49:14 UTC
I think that you're right. Looking at syspref names, I think this is the only one that starts with "OPACDisable" while there are a number with "OpacAllow" or "OPACAllow". 

The original intention here was to make it easily backwards compatible.

In Koha, the default is to allow OPAC send list, so if you did rename the syspref to "OPACAllowSendList" where 0 is "Don't allow" and 1 is "Allow", you'll have to remember to do a database update to flip all the values for "OPACAllowSendList".