| Summary: | Invalid markup in cookie consent modal | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | Pushed to oldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.04,24.11.10
|
|
| Circulation function: | |||
| Attachments: |
Bug 40614: Invalid markup in cookie consent modal
Bug 40614: Invalid markup in cookie consent modal Bug 40614: Invalid markup in cookie consent modal Bug 40614: Invalid markup in cookie consent modal |
||
|
Description
Owen Leonard
2025-08-07 16:22:01 UTC
Created attachment 185232 [details] [review] Bug 40614: Invalid markup in cookie consent modal This patch corrects a minor markup error in the OPAC's cookie consent modal, removing a "type" attribute from an <a> tag. To test apply the patch and make sure you have the CookieConsent system preference enabled. - Go to the OPAC. You should see a cookie consent banner across the bottom of the page. - Click "More information." - Click "Cancel" in the modal window. The modal should close. Sponsored-by: Athens County Public Libraries Created attachment 186154 [details] [review] Bug 40614: Invalid markup in cookie consent modal This patch corrects a minor markup error in the OPAC's cookie consent modal, removing a "type" attribute from an <a> tag. To test apply the patch and make sure you have the CookieConsent system preference enabled. - Go to the OPAC. You should see a cookie consent banner across the bottom of the page. - Click "More information." - Click "Cancel" in the modal window. The modal should close. Sponsored-by: Athens County Public Libraries Signed-off-by: noah <noah@inlibro.com> I need more info to setup the cookie consent. Created attachment 186607 [details] [review] Bug 40614: Invalid markup in cookie consent modal This patch corrects a minor markup error in the OPAC's cookie consent modal, removing a "type" attribute from an <a> tag. To test apply the patch and make sure you have the CookieConsent system preference enabled. - Go to the OPAC. You should see a cookie consent banner across the bottom of the page. - Click "More information." - Click "Cancel" in the modal window. The modal should close. Sponsored-by: Athens County Public Libraries Signed-off-by: noah <noah@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 186614 [details] [review] Bug 40614: Invalid markup in cookie consent modal This patch corrects a minor markup error in the OPAC's cookie consent modal, removing a "type" attribute from an <a> tag. To test apply the patch and make sure you have the CookieConsent system preference enabled. - Go to the OPAC. You should see a cookie consent banner across the bottom of the page. - Click "More information." - Click "Cancel" in the modal window. The modal should close. Sponsored-by: Athens County Public Libraries Signed-off-by: Noah Tremblay <noah.tremblay@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Adjusted Noah's signed-off-by line. Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.10 |