Bug 40614 - Invalid markup in cookie consent modal
Summary: Invalid markup in cookie consent modal
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-07 16:22 UTC by Owen Leonard
Modified: 2025-09-25 16:30 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.04
Circulation function:


Attachments
Bug 40614: Invalid markup in cookie consent modal (1.62 KB, patch)
2025-08-07 16:35 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40614: Invalid markup in cookie consent modal (1.66 KB, patch)
2025-09-04 14:04 UTC, Noah Tremblay
Details | Diff | Splinter Review
Bug 40614: Invalid markup in cookie consent modal (1.76 KB, patch)
2025-09-19 08:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 40614: Invalid markup in cookie consent modal (1.74 KB, patch)
2025-09-19 09:34 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-08-07 16:22:01 UTC
The W3C validator complains about a "type" attribute on an <a> tag. It can be safely removed.
Comment 1 Owen Leonard 2025-08-07 16:35:31 UTC
Created attachment 185232 [details] [review]
Bug 40614: Invalid markup in cookie consent modal

This patch corrects a minor markup error in the OPAC's cookie consent
modal, removing a "type" attribute from an <a> tag.

To test apply the patch and make sure you have the CookieConsent system
preference enabled.

- Go to the OPAC. You should see a cookie consent banner across the
  bottom of the page.
- Click "More information."
- Click "Cancel" in the modal window. The modal should close.

Sponsored-by: Athens County Public Libraries
Comment 2 Noah Tremblay 2025-09-04 14:04:34 UTC
Created attachment 186154 [details] [review]
Bug 40614: Invalid markup in cookie consent modal

This patch corrects a minor markup error in the OPAC's cookie consent
modal, removing a "type" attribute from an <a> tag.

To test apply the patch and make sure you have the CookieConsent system
preference enabled.

- Go to the OPAC. You should see a cookie consent banner across the
  bottom of the page.
- Click "More information."
- Click "Cancel" in the modal window. The modal should close.

Sponsored-by: Athens County Public Libraries
Signed-off-by: noah <noah@inlibro.com>
Comment 3 Jonathan Druart 2025-09-16 10:20:50 UTC
I need more info to setup the cookie consent.
Comment 4 Marcel de Rooy 2025-09-19 08:09:32 UTC
Created attachment 186607 [details] [review]
Bug 40614: Invalid markup in cookie consent modal

This patch corrects a minor markup error in the OPAC's cookie consent
modal, removing a "type" attribute from an <a> tag.

To test apply the patch and make sure you have the CookieConsent system
preference enabled.

- Go to the OPAC. You should see a cookie consent banner across the
  bottom of the page.
- Click "More information."
- Click "Cancel" in the modal window. The modal should close.

Sponsored-by: Athens County Public Libraries
Signed-off-by: noah <noah@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Jonathan Druart 2025-09-19 09:34:18 UTC
Created attachment 186614 [details] [review]
Bug 40614: Invalid markup in cookie consent modal

This patch corrects a minor markup error in the OPAC's cookie consent
modal, removing a "type" attribute from an <a> tag.

To test apply the patch and make sure you have the CookieConsent system
preference enabled.

- Go to the OPAC. You should see a cookie consent banner across the
  bottom of the page.
- Click "More information."
- Click "Cancel" in the modal window. The modal should close.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Noah Tremblay <noah.tremblay@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Jonathan Druart 2025-09-19 09:34:40 UTC
Adjusted Noah's signed-off-by line.
Comment 7 Lucas Gass (lukeg) 2025-09-19 14:45:04 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 8 Paul Derscheid 2025-09-25 16:30:20 UTC
Nice work everyone!

Pushed to 25.05.x