Bug 40664

Summary: Serial subscription input missing "Required" labels
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: TemplatesAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: Pushed to stable --- QA Contact: Lisette Scheer <lisette>
Severity: minor    
Priority: P5 - low CC: david, lisette
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the second page of the new serial subscription form - it adds missing "Required" labels next to two mandatory fields ('Frequency' and 'Subscription start date').
Version(s) released in:
25.11.00,25.05.06
Circulation function:
Attachments: Bug 40664: Serial subscription input missing "Required" labels
Bug 40664: Serial subscription input missing "Required" labels
Bug 40664: Serial subscription input missing "Required" labels

Description Caroline Cyr La Rose 2025-08-18 13:36:33 UTC
On the second page of the 'Add a new [serial] subscription' form, there are fields that are mandatory (in red), but it doesn't say 'Required' next to them.

To recreate:
1. Go to Serials
2. Click 'New subscription'
3. Enter a biblionumber in the 'Record' field (e.g. 230)
4. Click 'Next'
5. (Click 'OK' to confirm that you are not adding a vendor)
--> On the page 'Add a new subscription (2/2)' the fields 'Frequency' and 'Subscription start date' are red to indicate that they are mandatory, but there is no 'Required' note next to them.
Comment 1 Caroline Cyr La Rose 2025-08-18 13:42:08 UTC
Created attachment 185514 [details] [review]
Bug 40664: Serial subscription input missing "Required" labels

This patch adds missing "Required" labels next to two mandatory fields
in the second page of the new serial subscription form.

To test:
1. Go to Serials
2. Click 'New subscription'
3. Enter a biblionumber in the 'Record' field (e.g. 230)
4. Click 'Next'
5. (Click 'OK' to confirm that you are not adding a vendor)
--> On the page 'Add a new subscription (2/2)' the fields 'Frequency' and 'Subscription start date' are red to indicate that they are mandatory, but there is no 'Required' note next to them.
6. Apply patch and refresh the page
--> It should say 'Required' next to all the mandatory fields (in red)
Comment 2 Caroline Cyr La Rose 2025-08-18 13:42:33 UTC
Correction based on bug 40413
Comment 3 David Nind 2025-11-11 10:22:45 UTC
Created attachment 189485 [details] [review]
Bug 40664: Serial subscription input missing "Required" labels

This patch adds missing "Required" labels next to two mandatory fields
in the second page of the new serial subscription form.

To test:
1. Go to Serials
2. Click 'New subscription'
3. Enter a biblionumber in the 'Record' field (e.g. 230)
4. Click 'Next'
5. (Click 'OK' to confirm that you are not adding a vendor)
--> On the page 'Add a new subscription (2/2)' the fields 'Frequency' and 'Subscription start date' are red to indicate that they are mandatory, but there is no 'Required' note next to them.
6. Apply patch and refresh the page
--> It should say 'Required' next to all the mandatory fields (in red)

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Lisette Scheer 2025-11-18 18:31:07 UTC
Created attachment 189676 [details] [review]
Bug 40664: Serial subscription input missing "Required" labels

This patch adds missing "Required" labels next to two mandatory fields
in the second page of the new serial subscription form.

To test:
1. Go to Serials
2. Click 'New subscription'
3. Enter a biblionumber in the 'Record' field (e.g. 230)
4. Click 'Next'
5. (Click 'OK' to confirm that you are not adding a vendor)
--> On the page 'Add a new subscription (2/2)' the fields 'Frequency' and 'Subscription start date' are red to indicate that they are mandatory, but there is no 'Required' note next to them.
6. Apply patch and refresh the page
--> It should say 'Required' next to all the mandatory fields (in red)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 5 Lucas Gass (lukeg) 2025-11-19 19:29:09 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Paul Derscheid 2025-11-25 16:30:44 UTC
Nice work everyone!

Pushed to 25.05.x