Bug 40413 - Patron list input missing "Required" label
Summary: Patron list input missing "Required" label
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-07-16 13:33 UTC by Caroline Cyr La Rose
Modified: 2025-08-01 19:25 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40413: Add "Required" label to patron list input (1.36 KB, patch)
2025-07-30 18:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40413: Add "Required" label to patron list input (1.43 KB, patch)
2025-07-30 18:33 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 40413: Add "Required" label to patron list input (1.49 KB, patch)
2025-08-01 13:48 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2025-07-16 13:33:38 UTC
When you create a patron list, the text in the input box for the list name is in red and italics. It should be black (or whatever the usual font colour is) and regular, even if the field is mandatory.

To recreate :
1. Go to Tools > Patron lists > New patron list
2. Type in the name of the list
   --> Notice the input text is red and italic
Comment 1 Owen Leonard 2025-07-17 10:41:42 UTC
The color is standard but patron name line is missing the "Required" label. The incorrect italic is Bug 39809.
Comment 2 Caroline Cyr La Rose 2025-07-17 20:47:48 UTC
Thanks Owen! I didn't know it was all the same bug. I can close it as duplicate.

I'm not sure what you mean by the patron name line? Is it in the patron_lists/add-modify.pl page?
Comment 3 Owen Leonard 2025-07-30 18:28:12 UTC
Created attachment 184912 [details] [review]
Bug 40413: Add "Required" label to patron list input

This patch adds the "Required" label to the patron list name field in
the form for creating a patron list. This makes it consistent with other
forms which has required fields.

To test, apply the patch and go to Tools -> Patron lists -> New patron
list.

The "Name" field should have a red label "Required" after it.

Sponsored-by: Athens County Public Libraries
Comment 4 Caroline Cyr La Rose 2025-07-30 18:33:57 UTC
Created attachment 184913 [details] [review]
Bug 40413: Add "Required" label to patron list input

This patch adds the "Required" label to the patron list name field in
the form for creating a patron list. This makes it consistent with other
forms which has required fields.

To test, apply the patch and go to Tools -> Patron lists -> New patron
list.

The "Name" field should have a red label "Required" after it.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 5 Nick Clemens (kidclamp) 2025-08-01 13:48:02 UTC
Created attachment 185010 [details] [review]
Bug 40413: Add "Required" label to patron list input

This patch adds the "Required" label to the patron list name field in
the form for creating a patron list. This makes it consistent with other
forms which has required fields.

To test, apply the patch and go to Tools -> Patron lists -> New patron
list.

The "Name" field should have a red label "Required" after it.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Lucas Gass (lukeg) 2025-08-01 19:25:14 UTC
Nice work everyone!

Pushed to main for 25.11