Bug 40675

Summary: Carriage return in patron note message breaks SIP
Product: Koha Reporter: Bernard <bernard.scaife>
Component: Self checkoutAssignee: Bugs List <koha-bugs>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 40675

Description Bernard 2025-08-20 10:21:01 UTC
If an OPAC message is pasted into a Koha patron's record which includes a carriage return, it breaks the line and SIP. A user at the Kiosk may find they can no longer log in to the SIP kiosk. The SIP2 specification uses the carriage return as the message terminator.
Comment 1 Bernard 2025-08-20 10:56:44 UTC
Created attachment 185583 [details] [review]
Bug 40675

Removes carriage returns from messages to prevent breaking SIP

Test
1. Find a user and click "Add message".
2. Choose "Add message for OPAC ... " from dropdown
3. In Word (or similar, type a message adding a carriage return in the middle of it.
4. Copy / paste this text into the message box and save.
5. Run the SIP emulator tool sip_cli_emulator.pl and observe that after the carriage return, the message has broken onto a new line.
6. Install patch
7. restart_all
8. Repeat above 1-5
9. Observe that runaway line is now joined to the previous line (correctly)