Bug 40675 - Carriage return in patron note message breaks SIP
Summary: Carriage return in patron note message breaks SIP
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-20 10:21 UTC by Bernard
Modified: 2025-08-20 10:57 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40675 (1.38 KB, patch)
2025-08-20 10:56 UTC, Bernard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard 2025-08-20 10:21:01 UTC
If an OPAC message is pasted into a Koha patron's record which includes a carriage return, it breaks the line and SIP. A user at the Kiosk may find they can no longer log in to the SIP kiosk. The SIP2 specification uses the carriage return as the message terminator.
Comment 1 Bernard 2025-08-20 10:56:44 UTC
Created attachment 185583 [details] [review]
Bug 40675

Removes carriage returns from messages to prevent breaking SIP

Test
1. Find a user and click "Add message".
2. Choose "Add message for OPAC ... " from dropdown
3. In Word (or similar, type a message adding a carriage return in the middle of it.
4. Copy / paste this text into the message box and save.
5. Run the SIP emulator tool sip_cli_emulator.pl and observe that after the carriage return, the message has broken onto a new line.
6. Install patch
7. restart_all
8. Repeat above 1-5
9. Observe that runaway line is now joined to the previous line (correctly)