Bug 40678

Summary: Choices are not remembered if a wrong transfer modal is generated
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: CirculationAssignee: Lucas Gass (lukeg) <lucas>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kyle
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This patchset fixes a bug where the "Drop box mode" and "Forgive overdue charges" checkbox values were not retained when a wrong transfer modal is displayed.
Version(s) released in:
Circulation function:
Attachments: Bug 40678: Add hidden value to remember dropboxmode selection
Bug 40678: Add hidden value to remember exemptfine selection

Description Lucas Gass (lukeg) 2025-08-20 13:55:47 UTC
To recreate:

1. Put an item in transfer to a different library than the logged in branch 
2. Go to Circulation > Check in 
3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 
4. See the "Book drop mode" choice is remembered after every selection.
5. Check in the item from step 1 to make a wrong transfer 
6. The modal pops up for wrong transfer, click confirm 
7. Now the choice of "Book drop mode" is forgotten.
Comment 1 Lucas Gass (lukeg) 2025-08-20 14:03:19 UTC
Created attachment 185587 [details] [review]
Bug 40678: Add hidden value to remember dropboxmode selection

To test:
1. Put an item in transfer to a different library than the logged in branch
2. Go to Circulation > Check in
3. Choose the "Book drop mode" option and check in a few items NOT from step 1.
4. See the "Book drop mode" choice is remembered after every selection.
5. Check in the item from step 1 to make a wrong transfer
6. The modal pops up for wrong transfer, click confirm
7. Now the choice of "Book drop mode" is forgotten.
8. APPLY PATCH
9. Try again, this time the "Book drop mode" selction should be retained
Comment 2 Lucas Gass (lukeg) 2025-08-20 14:16:25 UTC
The same is true for "Forgive overdue charges", I think we can also fix that here.
Comment 3 Lucas Gass (lukeg) 2025-08-20 14:18:35 UTC
Created attachment 185588 [details] [review]
Bug 40678: Add hidden value to remember exemptfine selection

To test:
-Same test plan as with "Book drop mode" but for "Forgive overdue charges"