Bug 40678 - Choices are not remembered if a wrong transfer modal is generated
Summary: Choices are not remembered if a wrong transfer modal is generated
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-20 13:55 UTC by Lucas Gass (lukeg)
Modified: 2025-08-20 14:42 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patchset fixes a bug where the "Drop box mode" and "Forgive overdue charges" checkbox values were not retained when a wrong transfer modal is displayed.
Version(s) released in:
Circulation function:


Attachments
Bug 40678: Add hidden value to remember dropboxmode selection (1.90 KB, patch)
2025-08-20 14:03 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40678: Add hidden value to remember exemptfine selection (1.43 KB, patch)
2025-08-20 14:18 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-08-20 13:55:47 UTC
To recreate:

1. Put an item in transfer to a different library than the logged in branch 
2. Go to Circulation > Check in 
3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 
4. See the "Book drop mode" choice is remembered after every selection.
5. Check in the item from step 1 to make a wrong transfer 
6. The modal pops up for wrong transfer, click confirm 
7. Now the choice of "Book drop mode" is forgotten.
Comment 1 Lucas Gass (lukeg) 2025-08-20 14:03:19 UTC
Created attachment 185587 [details] [review]
Bug 40678: Add hidden value to remember dropboxmode selection

To test:
1. Put an item in transfer to a different library than the logged in branch
2. Go to Circulation > Check in
3. Choose the "Book drop mode" option and check in a few items NOT from step 1.
4. See the "Book drop mode" choice is remembered after every selection.
5. Check in the item from step 1 to make a wrong transfer
6. The modal pops up for wrong transfer, click confirm
7. Now the choice of "Book drop mode" is forgotten.
8. APPLY PATCH
9. Try again, this time the "Book drop mode" selction should be retained
Comment 2 Lucas Gass (lukeg) 2025-08-20 14:16:25 UTC
The same is true for "Forgive overdue charges", I think we can also fix that here.
Comment 3 Lucas Gass (lukeg) 2025-08-20 14:18:35 UTC
Created attachment 185588 [details] [review]
Bug 40678: Add hidden value to remember exemptfine selection

To test:
-Same test plan as with "Book drop mode" but for "Forgive overdue charges"