Bug 40678 - Choices are not remembered if a wrong transfer modal is generated
Summary: Choices are not remembered if a wrong transfer modal is generated
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-20 13:55 UTC by Lucas Gass (lukeg)
Modified: 2025-10-10 13:06 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patchset fixes a bug where the "Drop box mode" and "Forgive overdue charges" checkbox values were not retained when a wrong transfer modal is displayed.
Version(s) released in:
25.11.00,25.05.04,24.11.10
Circulation function:


Attachments
Bug 40678: Add hidden value to remember dropboxmode selection (1.90 KB, patch)
2025-08-20 14:03 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40678: Add hidden value to remember exemptfine selection (1.43 KB, patch)
2025-08-20 14:18 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40678: Add hidden value to remember dropboxmode selection (1.95 KB, patch)
2025-08-25 22:36 UTC, WPPL Sandboxes
Details | Diff | Splinter Review
Bug 40678: Add hidden value to remember exemptfine selection (1.48 KB, patch)
2025-08-25 22:36 UTC, WPPL Sandboxes
Details | Diff | Splinter Review
Bug 40678: Add hidden value to remember dropboxmode selection (2.04 KB, patch)
2025-08-29 06:54 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 40678: Add hidden value to remember exemptfine selection (1.58 KB, patch)
2025-08-29 06:54 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-08-20 13:55:47 UTC
To recreate:

1. Put an item in transfer to a different library than the logged in branch 
2. Go to Circulation > Check in 
3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 
4. See the "Book drop mode" choice is remembered after every selection.
5. Check in the item from step 1 to make a wrong transfer 
6. The modal pops up for wrong transfer, click confirm 
7. Now the choice of "Book drop mode" is forgotten.
Comment 1 Lucas Gass (lukeg) 2025-08-20 14:03:19 UTC
Created attachment 185587 [details] [review]
Bug 40678: Add hidden value to remember dropboxmode selection

To test:
1. Put an item in transfer to a different library than the logged in branch
2. Go to Circulation > Check in
3. Choose the "Book drop mode" option and check in a few items NOT from step 1.
4. See the "Book drop mode" choice is remembered after every selection.
5. Check in the item from step 1 to make a wrong transfer
6. The modal pops up for wrong transfer, click confirm
7. Now the choice of "Book drop mode" is forgotten.
8. APPLY PATCH
9. Try again, this time the "Book drop mode" selction should be retained
Comment 2 Lucas Gass (lukeg) 2025-08-20 14:16:25 UTC
The same is true for "Forgive overdue charges", I think we can also fix that here.
Comment 3 Lucas Gass (lukeg) 2025-08-20 14:18:35 UTC
Created attachment 185588 [details] [review]
Bug 40678: Add hidden value to remember exemptfine selection

To test:
-Same test plan as with "Book drop mode" but for "Forgive overdue charges"
Comment 4 WPPL Sandboxes 2025-08-25 22:36:38 UTC
Created attachment 185777 [details] [review]
Bug 40678: Add hidden value to remember dropboxmode selection

To test:
1. Put an item in transfer to a different library than the logged in branch
2. Go to Circulation > Check in
3. Choose the "Book drop mode" option and check in a few items NOT from step 1.
4. See the "Book drop mode" choice is remembered after every selection.
5. Check in the item from step 1 to make a wrong transfer
6. The modal pops up for wrong transfer, click confirm
7. Now the choice of "Book drop mode" is forgotten.
8. APPLY PATCH
9. Try again, this time the "Book drop mode" selction should be retained

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Comment 5 WPPL Sandboxes 2025-08-25 22:36:40 UTC
Created attachment 185778 [details] [review]
Bug 40678: Add hidden value to remember exemptfine selection

To test:
-Same test plan as with "Book drop mode" but for "Forgive overdue charges"

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Comment 6 CJ Lynce 2025-08-25 22:40:19 UTC
Patch works as advertised, both 'Book drop mode' and 'Forgive Overdue Charges' are remembered when the 'wrong transfer' modal is generated.

Testing notes: Enable 'finesMode' syspref to test 'Forgive Overdue Charges' checkbox.

Thank you!
Comment 7 Lucas Gass (lukeg) 2025-08-26 13:34:08 UTC
> Testing notes: Enable 'finesMode' syspref to test 'Forgive Overdue Charges'
> checkbox.

Thanks for pointing that out, CJ!
Comment 8 Marcel de Rooy 2025-08-29 06:54:24 UTC
Created attachment 185871 [details] [review]
Bug 40678: Add hidden value to remember dropboxmode selection

To test:
1. Put an item in transfer to a different library than the logged in branch
2. Go to Circulation > Check in
3. Choose the "Book drop mode" option and check in a few items NOT from step 1.
4. See the "Book drop mode" choice is remembered after every selection.
5. Check in the item from step 1 to make a wrong transfer
6. The modal pops up for wrong transfer, click confirm
7. Now the choice of "Book drop mode" is forgotten.
8. APPLY PATCH
9. Try again, this time the "Book drop mode" selction should be retained

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2025-08-29 06:54:26 UTC
Created attachment 185872 [details] [review]
Bug 40678: Add hidden value to remember exemptfine selection

To test:
-Same test plan as with "Book drop mode" but for "Forgive overdue charges"

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Lucas Gass (lukeg) 2025-08-29 16:47:20 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 11 Paul Derscheid 2025-09-20 08:59:26 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 12 Fridolin Somers 2025-10-10 13:06:03 UTC
Pushed to 24.11.x for 24.11.10