To recreate: 1. Put an item in transfer to a different library than the logged in branch 2. Go to Circulation > Check in 3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 4. See the "Book drop mode" choice is remembered after every selection. 5. Check in the item from step 1 to make a wrong transfer 6. The modal pops up for wrong transfer, click confirm 7. Now the choice of "Book drop mode" is forgotten.
Created attachment 185587 [details] [review] Bug 40678: Add hidden value to remember dropboxmode selection To test: 1. Put an item in transfer to a different library than the logged in branch 2. Go to Circulation > Check in 3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 4. See the "Book drop mode" choice is remembered after every selection. 5. Check in the item from step 1 to make a wrong transfer 6. The modal pops up for wrong transfer, click confirm 7. Now the choice of "Book drop mode" is forgotten. 8. APPLY PATCH 9. Try again, this time the "Book drop mode" selction should be retained
The same is true for "Forgive overdue charges", I think we can also fix that here.
Created attachment 185588 [details] [review] Bug 40678: Add hidden value to remember exemptfine selection To test: -Same test plan as with "Book drop mode" but for "Forgive overdue charges"
Created attachment 185777 [details] [review] Bug 40678: Add hidden value to remember dropboxmode selection To test: 1. Put an item in transfer to a different library than the logged in branch 2. Go to Circulation > Check in 3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 4. See the "Book drop mode" choice is remembered after every selection. 5. Check in the item from step 1 to make a wrong transfer 6. The modal pops up for wrong transfer, click confirm 7. Now the choice of "Book drop mode" is forgotten. 8. APPLY PATCH 9. Try again, this time the "Book drop mode" selction should be retained Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Created attachment 185778 [details] [review] Bug 40678: Add hidden value to remember exemptfine selection To test: -Same test plan as with "Book drop mode" but for "Forgive overdue charges" Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Patch works as advertised, both 'Book drop mode' and 'Forgive Overdue Charges' are remembered when the 'wrong transfer' modal is generated. Testing notes: Enable 'finesMode' syspref to test 'Forgive Overdue Charges' checkbox. Thank you!
> Testing notes: Enable 'finesMode' syspref to test 'Forgive Overdue Charges' > checkbox. Thanks for pointing that out, CJ!
Created attachment 185871 [details] [review] Bug 40678: Add hidden value to remember dropboxmode selection To test: 1. Put an item in transfer to a different library than the logged in branch 2. Go to Circulation > Check in 3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 4. See the "Book drop mode" choice is remembered after every selection. 5. Check in the item from step 1 to make a wrong transfer 6. The modal pops up for wrong transfer, click confirm 7. Now the choice of "Book drop mode" is forgotten. 8. APPLY PATCH 9. Try again, this time the "Book drop mode" selction should be retained Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 185872 [details] [review] Bug 40678: Add hidden value to remember exemptfine selection To test: -Same test plan as with "Book drop mode" but for "Forgive overdue charges" Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.10