|
Description
Marcel de Rooy
2025-08-26 12:10:22 UTC
You can `git grep data-toggle` to find occurrences. They should all be replaced with data-bs-toggle. Created attachment 191737 [details] [review] Bug 40703: Replaced data-toggle with data-bs-toggle Created attachment 191799 [details] [review] Bug 40703: Replaced data-toggle with data-bs-toggle Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 191800 [details] [review] Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js Signed-off-by: Owen Leonard <oleonard@myacpl.org> (In reply to Owen Leonard from comment #4) > Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js Reverted because we don't want to change official Bootstrap assets. This fix looks perfect, Passing QA here. Thanks Aya! Created attachment 191844 [details] [review] Bug 40703: Replaced data-toggle with data-bs-toggle Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 191845 [details] [review] Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 191964 [details] [review] Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> QA tool reports: [WARN] koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.js WARN spelling trough ==> through othwerise ==> otherwise trough ==> through Maybe we can ignore that since this is a Bootstrap asset, but I would prefer if we didn't change the BS file and then revert the change in the same patchset. Created attachment 192145 [details] [review] Bug 40703: Replaced data-toggle with data-bs-toggle Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Nice work everyone! Pushed to main for 26.05 |