Summary: | DBRev 23.12.00.053 should be made more resilient | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Architecture, internals, and plumbing | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Pushed to main --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00
|
Circulation function: | |
Bug Depends on: | 37901, 36755 | ||
Bug Blocks: | |||
Attachments: |
Bug 40725: Add TableExists check to db_revs/231200053.pl
Bug 40725: Add TableExists check to db_revs/231200053.pl |
Description
Lucas Gass (lukeg)
2025-08-28 17:55:33 UTC
The DBRev is DBRev 23.12.00.053 not DBRev 23.12.00.003 Created attachment 185856 [details] [review] Bug 40725: Add TableExists check to db_revs/231200053.pl Created attachment 185857 [details] [review] Bug 40725: Add TableExists check to db_revs/231200053.pl This patch makes the DB revision idempotent. To test: 1. Fix the Koha version right before the broken upgrade: $ ktd --shell k$ koha-mysql kohadev > UPDATE systempreferences SET value="23.1200052" WHERE variable="version"; \q 2. Restart everything (memcached should be enough) k$ restart_all 3. Run: k$ updatedatabase => FAIL: You get: ```shell Upgrade to 23.12.00.053 [19:34:35]: Bug 36755 - Increase length of 'code' column in borrower_attribute_types ERROR: C4::Installer::foreign_key_exists(): DBI Exception: DBD::mysql::db selectrow_array failed: Table 'koha_kohadev.pseudonymized_borrower_attributes' doesn't exist at /kohadevbox/koha/installer/data/mysql/db_revs/231200053.pl line 11 ``` 4. Apply this patch 5. Repeat 3 => SUCCESS: Update runs smoothly! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Thank you Tomas for testing and for the test plan! Thanks all! Pushed to main for 25.11.x Hi guys, thank you for this and apologies for the issues caused. |