Summary: | Selections toolbar buttons should not be focusable when they are inactive | ||
---|---|---|---|
Product: | Koha | Reporter: | Jake Deery <jake.deery> |
Component: | OPAC | Assignee: | Jake Deery <jake.deery> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | jake.deery |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 40782: Selections toolbar checkbox now adds tabindex -1
Bug 40782: Selections toolbar checkbox now adds tabindex -1 Bug 40782: (follow-up) Tidy results-list.js |
Description
Jake Deery
2025-09-10 09:08:17 UTC
Created attachment 186310 [details] [review] Bug 40782: Selections toolbar checkbox now adds tabindex -1 This patch now sets tabindex to -1 if a disabled class is applied to a control, and removes it when the class evaporates. This improves accessibility by making these disabled items non-focusable. To test: a) make a search on the OPAC b) tab through the selections toolbar, notice how visually disabled items are focusable APPLY PATCH c) repeat steps a-b, notice how the elements are no longer focusable SIGN OFF Created attachment 186318 [details] [review] Bug 40782: Selections toolbar checkbox now adds tabindex -1 This patch now sets tabindex to -1 if a disabled class is applied to a control, and removes it when the class evaporates. This improves accessibility by making these disabled items non-focusable. To test: a) make a search on the OPAC b) tab through the selections toolbar, notice how visually disabled items are focusable APPLY PATCH c) repeat steps a-b, notice how the elements are no longer focusable SIGN OFF Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 186319 [details] [review] Bug 40782: (follow-up) Tidy results-list.js Tidy converts single quotes to double quotes Signed-off-by: Owen Leonard <oleonard@myacpl.org> |