On the results page, some toolbar buttons have a disabled class, but can still be focused. This should not be possible, as it is misleading for users of a screen reader.
Created attachment 186310 [details] [review] Bug 40782: Selections toolbar checkbox now adds tabindex -1 This patch now sets tabindex to -1 if a disabled class is applied to a control, and removes it when the class evaporates. This improves accessibility by making these disabled items non-focusable. To test: a) make a search on the OPAC b) tab through the selections toolbar, notice how visually disabled items are focusable APPLY PATCH c) repeat steps a-b, notice how the elements are no longer focusable SIGN OFF
Created attachment 186318 [details] [review] Bug 40782: Selections toolbar checkbox now adds tabindex -1 This patch now sets tabindex to -1 if a disabled class is applied to a control, and removes it when the class evaporates. This improves accessibility by making these disabled items non-focusable. To test: a) make a search on the OPAC b) tab through the selections toolbar, notice how visually disabled items are focusable APPLY PATCH c) repeat steps a-b, notice how the elements are no longer focusable SIGN OFF Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 186319 [details] [review] Bug 40782: (follow-up) Tidy results-list.js Tidy converts single quotes to double quotes Signed-off-by: Owen Leonard <oleonard@myacpl.org>