| Summary: | The bookbag_form should not be submittable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jake Deery <jake.deery> |
| Component: | OPAC | Assignee: | Jake Deery <jake.deery> |
| Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | jake.deery, jonathan.druart, philip.orr |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
Bug 40783: Fix erroneous bookbag_form submission
Bug 40783: Result page checkbox now triggers click Bug 40783: Result page checkbox now triggers click [ALTERNATIVE PATCH] Bug 40783: Use existing noEnterSubmit class |
||
|
Description
Jake Deery
2025-09-10 09:12:17 UTC
Created attachment 186311 [details] [review] Bug 40783: Fix erroneous bookbag_form submission This patch addresses a bug where pressing return when focused on the bookbag_form checkbox results in a form submission. The bookbag_form is not designed to be submitted, so the behaviour has been disabled for accessibility reasons. TO TEST: a) go to /cgi-bin/koha/opac-search.pl?idx=kw&q=history&sort_by=relevance b) add an item to your cart (ensure the syspref is enabled) c) tab through the results until you come across a checkbox, press return d) notice your page refresh, a form submission has happened APPLY PATCH e) repeat steps a-c f) notice the page no longer refreshes, and that no form submission occurs g) notice the items are still in your cart and can be interacted with normally SIGN OFF Created attachment 186789 [details] [review] Bug 40783: Result page checkbox now triggers click This patch changes the behaviour off the checkboxes on the results page, so that instead of causing a form submission (essentially, a page refresh), the checkbox will now follow the same behaviour as if it were clicked. TO TEST: a) go to /cgi-bin/koha/opac-search.pl?idx=kw&q=history&sort_by=relevance b) add an item to your cart (ensure the syspref is enabled) c) tab through the results until you come across a checkbox, press return d) notice your page refreshes, as a form submission has happened APPLY PATCH e) repeat steps a-c f) notice the page no longer refreshes, and that no form submission occurs g) notice that the checkbox is now checked, as if it had been clicked h) notice the items are still in your cart and can be interacted with normally SIGN OFF Slightly rewritten this patch, as the old one broke the sort_by dropdown on the results page. Works for me, but qa fails tidiness:
ยดยดยด
Result:
[FAIL] koha-tmpl/opac-tmpl/bootstrap/js/results-list.js
FAIL tidiness
File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/js/results-list.js`
```
Happy to sign off anyway.
Also just to amend the patch notes:
Step e) repeat steps a-c
First you should clear your local cache and reload the page.
Otherwise the old js may be still cached :)
Created attachment 187201 [details] [review] Bug 40783: Result page checkbox now triggers click This patch changes the behaviour off the checkboxes on the results page, so that instead of causing a form submission (essentially, a page refresh), the checkbox will now follow the same behaviour as if it were clicked. TO TEST: a) go to /cgi-bin/koha/opac-search.pl?idx=kw&q=history&sort_by=relevance b) add an item to your cart (ensure the syspref is enabled) c) tab through the results until you come across a checkbox, press return d) notice your page refreshes, as a form submission has happened APPLY PATCH e) repeat steps a-c f) notice the page no longer refreshes, and that no form submission occurs g) notice that the checkbox is now checked, as if it had been clicked h) notice the items are still in your cart and can be interacted with normally SIGN OFF Signed-off-by: John Doe <you@example.com> Created attachment 187457 [details] [review] [ALTERNATIVE PATCH] Bug 40783: Use existing noEnterSubmit class Jake, please have a look at this patch, I think it's what you need here. |