Bug 40783 - The bookbag_form should not be submittable
Summary: The bookbag_form should not be submittable
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Jake Deery
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-09-10 09:12 UTC by Jake Deery
Modified: 2025-09-10 16:20 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40783: Fix erroneous bookbag_form submission (1.55 KB, patch)
2025-09-10 09:13 UTC, Jake Deery
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Deery 2025-09-10 09:12:17 UTC
The bookbag_form on the OPAC search results page should not submit by default. This causes accessibility problems, as it appears as though a page refresh occurs needlessly.
Comment 1 Jake Deery 2025-09-10 09:13:58 UTC
Created attachment 186311 [details] [review]
Bug 40783: Fix erroneous bookbag_form submission

This patch addresses a bug where pressing return when focused on the
bookbag_form checkbox results in a form submission. The bookbag_form is
not designed to be submitted, so the behaviour has been disabled for
accessibility reasons.

TO TEST:
a)  go to /cgi-bin/koha/opac-search.pl?idx=kw&q=history&sort_by=relevance
b)  add an item to your cart (ensure the syspref is enabled)
c)  tab through the results until you come across a checkbox, press
return
d)  notice your page refresh, a form submission has happened
APPLY PATCH
e)  repeat steps a-c
f)  notice the page no longer refreshes, and that no form submission
occurs
g)  notice the items are still in your cart and can be interacted with
normally
SIGN OFF