| Summary: | Fix +add note function on payment table | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Juliet Heltibridle <jheltibridle> |
| Component: | Fines and fees | Assignee: | Lisette Scheer <lisette> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, lisette, mathsabypro |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: |
This updates the tables for a patron's accounting 'Make a payment' tab (members/pay.pl) and 'Transactions' tab to use a consistent UI when adding and editing the notes field, using a pop-up window for adding and edit a note.
An 'Edit' action button is now used to edit all existing notes (which opens a pop-up window to edit the note).
An 'Add' action button is now used to add a new note (which opens a pop-up window to add a note).
|
|
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 23674 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 40795: Fix +add note function on payment table
Bug 40795: Fix +add note function on payment table Screenshots - before and after the patch |
||
|
Description
Juliet Heltibridle
2025-09-11 17:40:49 UTC
I'm noticing now that Koha does actually save the contents of what you typed into the form, but it stays "open" for editing when you are on the add transaction page, which makes it look like it's not going to save when you navigate away from the page. So I think the actual fix we need is to have Koha give the user some indication that the note is saved, and then to "close" the form until an edit button is clicked again. Created attachment 187310 [details] [review] Bug 40795: Fix +add note function on payment table This patch updates the table on members/pay.pl to have consistant ui with the transactions table, using a modal. On members/pay.pl if there's no note, a note can still be added without the edit permission to allow for notes at time of payment, consistent with current behavior. I also updated the logic with the buttons on both pages to show as "add" when there's not a note present. To test: 1. Before applying patches, navigate to a user in your test environment (I used 23529000035676) 2. Click "Accounting" in the left hand link list 3. Create manual invoice, give it an amount but no note 4. Create another manual invoice, give it an amount and any note. 5. Navigate to "Transactions" observe both notes have an edit button. 6. Click edit on the one with a note, update it, and save. Note it has been updated. 7. Navigate to "Make a payment" Observe both columns have a text box that's immediately editable. The note should be filled on the charge with a note. 8. Apply the patch 9. Repeat step 5, observe the column with no note says "Add" now. 10. Repeat step 7, observe the payment note field matches the "note" field on transactions. 11. Edit the existing note and save 12. Add a new note for the other transaction and save. Created attachment 188507 [details] [review] Bug 40795: Fix +add note function on payment table This patch updates the table on members/pay.pl to have consistant ui with the transactions table, using a modal. On members/pay.pl if there's no note, a note can still be added without the edit permission to allow for notes at time of payment, consistent with current behavior. I also updated the logic with the buttons on both pages to show as "add" when there's not a note present. To test: 1. Before applying patches, navigate to a user in your test environment (I used 23529000035676) 2. Click "Accounting" in the left hand link list 3. Create manual invoice, give it an amount but no note 4. Create another manual invoice, give it an amount and any note. 5. Navigate to "Transactions" observe both notes have an edit button. 6. Click edit on the one with a note, update it, and save. Note it has been updated. 7. Navigate to "Make a payment" Observe both columns have a text box that's immediately editable. The note should be filled on the charge with a note. 8. Apply the patch 9. Repeat step 5, observe the column with no note says "Add" now. 10. Repeat step 7, observe the payment note field matches the "note" field on transactions. 11. Edit the existing note and save 12. Add a new note for the other transaction and save. Signed-off-by: David Nind <david@davidnind.com> Created attachment 188508 [details]
Screenshots - before and after the patch
I've attached screenshots before and after the patch.
- Transactions tab:
. Transaction with no note: no text and an 'Edit' action button ==> no text and an '+ Add' action button
. Transaction with a note: the text and an 'Edit' action button ==> the text and a 'Edit' action button (no change)
- Make a payment tab:
. Transaction with no note: '+ Add note' link ==> '+ Add' action button
. Transaction with a note: an editable note field ==> the text and an 'Edit' action button
Both are now consistent after the patch.
|