| Summary: | Users cannot renew overdue items from 'Overdue' tab in account | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Pushed to stable --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
25.11.00,25.05.04
|
Circulation function: | |
| Attachments: |
Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account
Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account Bug 40803: Remove two unused parameter |
||
|
Description
Nick Clemens (kidclamp)
2025-09-12 17:15:05 UTC
Created attachment 186387 [details] [review] Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account To test: 1 - Check out an item to a patron, backdated to be overdue 2 - Log in as that user to the OPAC 3 - From 'Your summary' - click the overdue tab, click renew 4 - 500 Error 5 - Apply patch 6 - Reload the page and repeat 7 - Success! Created attachment 186391 [details] [review] Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account To test: 1 - Check out an item to a patron, backdated to be overdue 2 - Log in as that user to the OPAC 3 - From 'Your summary' - click the overdue tab, click renew 4 - 500 Error 5 - Apply patch 6 - Reload the page and repeat 7 - Success! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 186404 [details] [review] Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account To test: 1 - Check out an item to a patron, backdated to be overdue 2 - Log in as that user to the OPAC 3 - From 'Your summary' - click the overdue tab, click renew 4 - 500 Error 5 - Apply patch 6 - Reload the page and repeat 7 - Success! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 186405 [details] [review] Bug 40803: Remove two unused parameter Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x (In reply to Jonathan Druart from comment #4) > Created attachment 186405 [details] [review] [review] > Bug 40803: Remove two unused parameter > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> We are not passing borrowernumber anymore here. What is the second parameter? When trying to apply this to 24.11 (manually with patch), a weird merge conflict comes up. The line numbers seem to be completely out of order. on master line 785 data-borrowernumber="[% ISSUE.borrowernumber | html %]" line 305 <input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]" /> ? line 543 <input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]" /> Did we only correct one instance out of 4 ? Needs more work ? |