Bug 40803 - Users cannot renew overdue items from 'Overdue' tab in account
Summary: Users cannot renew overdue items from 'Overdue' tab in account
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-09-12 17:15 UTC by Nick Clemens (kidclamp)
Modified: 2025-10-16 06:01 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.04
Circulation function:


Attachments
Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account (2.85 KB, patch)
2025-09-12 17:17 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account (2.91 KB, patch)
2025-09-13 14:02 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account (2.98 KB, patch)
2025-09-15 14:09 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40803: Remove two unused parameter (2.67 KB, patch)
2025-09-15 14:09 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2025-09-12 17:15:05 UTC
Looks like this was missed in the CSRF update
Comment 1 Nick Clemens (kidclamp) 2025-09-12 17:17:14 UTC
Created attachment 186387 [details] [review]
Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account

To test:
1 - Check out an item to a patron, backdated to be overdue
2 - Log in as that user to the OPAC
3 - From 'Your summary' - click the overdue tab, click renew
4 - 500 Error
5 - Apply patch
6 - Reload the page and repeat
7 - Success!
Comment 2 Lucas Gass (lukeg) 2025-09-13 14:02:24 UTC
Created attachment 186391 [details] [review]
Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account

To test:
1 - Check out an item to a patron, backdated to be overdue
2 - Log in as that user to the OPAC
3 - From 'Your summary' - click the overdue tab, click renew
4 - 500 Error
5 - Apply patch
6 - Reload the page and repeat
7 - Success!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2025-09-15 14:09:38 UTC
Created attachment 186404 [details] [review]
Bug 40803: Use submit form link to submit renewals from overdue items tab in opac user account

To test:
1 - Check out an item to a patron, backdated to be overdue
2 - Log in as that user to the OPAC
3 - From 'Your summary' - click the overdue tab, click renew
4 - 500 Error
5 - Apply patch
6 - Reload the page and repeat
7 - Success!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2025-09-15 14:09:41 UTC
Created attachment 186405 [details] [review]
Bug 40803: Remove two unused parameter

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Lucas Gass (lukeg) 2025-09-18 19:54:50 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Paul Derscheid 2025-09-25 16:31:20 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 7 Marcel de Rooy 2025-10-01 11:54:30 UTC
(In reply to Jonathan Druart from comment #4)
> Created attachment 186405 [details] [review] [review]
> Bug 40803: Remove two unused parameter
> 
> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

We are not passing borrowernumber anymore here. What is the second parameter?

When trying to apply this to 24.11 (manually with patch), a weird merge conflict comes up. The line numbers seem to be completely out of order.
Comment 8 Marcel de Rooy 2025-10-01 12:01:07 UTC
on master line 785
data-borrowernumber="[% ISSUE.borrowernumber | html %]"
Comment 9 Marcel de Rooy 2025-10-01 12:04:56 UTC
line 305 <input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]" /> ?

line 543
<input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]" />

Did we only correct one instance out of 4 ?
Comment 10 Fridolin Somers 2025-10-16 06:01:56 UTC
Needs more work ?