Bug 40816

Summary: Upgrade DataTables from 2.1.8 to >2.3.4
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Staff interfaceAssignee: Bugs List <koha-bugs>
Status: In Discussion --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, oleonard, paul.derscheid
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 36640    
Bug Blocks: 38259    
Attachments: Bug 40816: DT - Update css and js files
Bug 40816: Cherry-pick previous manual changes after update
Bug 40816: [DO NOT PUSH] Use .css instead of .min.css
Bug 40816: Fix sort icons

Description Jonathan Druart 2025-09-16 08:15:18 UTC
eg. bug 38259 needs DataTables 2.3+ for lengthLabels
Comment 1 Jonathan Druart 2025-09-16 08:19:26 UTC
Created attachment 186448 [details] [review]
Bug 40816: DT - Update css and js files
Comment 2 Jonathan Druart 2025-09-16 08:19:34 UTC
Created attachment 186449 [details] [review]
Bug 40816: Cherry-pick previous manual changes after update

This is a cherry-pick of
  commit e0193051e173557351d3da6697cb5f9c3e801185
  Bug 36640: (follow-up) CSS fixes for DataTables controls

I have only kept the changes to datatables.css
Comment 3 Jonathan Druart 2025-09-16 08:19:40 UTC
Created attachment 186450 [details] [review]
Bug 40816: [DO NOT PUSH] Use .css instead of .min.css

What the clean way to generate the min version?
Comment 4 Jonathan Druart 2025-09-16 08:19:48 UTC
Created attachment 186451 [details] [review]
Bug 40816: Fix sort icons
Comment 5 Jonathan Druart 2025-09-16 08:21:02 UTC
Why do we have a lot of duplicated CSS rules between _tables.scss and _common.scss?

Shouldn't all the .dataTable rules from _common be moved to _tables?