|
Description
Jonathan Druart
2025-09-16 08:15:18 UTC
Created attachment 186448 [details] [review] Bug 40816: DT - Update css and js files Created attachment 186449 [details] [review] Bug 40816: Cherry-pick previous manual changes after update This is a cherry-pick of commit e0193051e173557351d3da6697cb5f9c3e801185 Bug 36640: (follow-up) CSS fixes for DataTables controls I have only kept the changes to datatables.css Created attachment 186450 [details] [review] Bug 40816: [DO NOT PUSH] Use .css instead of .min.css What the clean way to generate the min version? Created attachment 186451 [details] [review] Bug 40816: Fix sort icons Why do we have a lot of duplicated CSS rules between _tables.scss and _common.scss? Shouldn't all the .dataTable rules from _common be moved to _tables? Created attachment 188979 [details] [review] Bug 40816: Remove !important from the min version (In reply to Jonathan Druart from comment #5) > Why do we have a lot of duplicated CSS rules between _tables.scss and > _common.scss? > > Shouldn't all the .dataTable rules from _common be moved to _tables? Let's do that on a separate bug report if needed. Created attachment 188991 [details] [review] Bug 40816: DT - Update css and js files Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 188992 [details] [review] Bug 40816: Cherry-pick previous manual changes after update This is a cherry-pick of commit e0193051e173557351d3da6697cb5f9c3e801185 Bug 36640: (follow-up) CSS fixes for DataTables controls I have only kept the changes to datatables.css Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 188993 [details] [review] Bug 40816: Fix sort icons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 188994 [details] [review] Bug 40816: Remove !important from the min version Signed-off-by: Owen Leonard <oleonard@myacpl.org> We should do the same for the OPAC shouldn't we? (In reply to Owen Leonard from comment #12) > We should do the same for the OPAC shouldn't we? Yes! The license details in the about page also needs updating. Created attachment 189599 [details] [review] Bug 40816: DT - Update css and js files - OPAC Patch from commit 372bfb4 Created attachment 189600 [details] [review] Bug 40816: Remove !important from css files - OPAC Patch from commit 20bdf8f Created attachment 189601 [details] [review] Bug 40816: Adjust about page Patch from commit 42a5269 It's still missing a "Fix sort icons" patch for the OPAC. Created attachment 189605 [details] [review] Bug 40816: (follow-up) CSS updates for table sorting icons Created attachment 189606 [details] [review] Bug 40816: (follow-up) CSS updates for table sorting icons Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> OPAC is ready for testing! :) Thanks Owen! This test fails with the patches: t/db_dependent/selenium/patrons_search.t # at t/db_dependent/selenium/patrons_search.t line 660. Error while executing command: no such element: Unable to locate element: //table[@id="memberresultst"]//th[@aria-label="Date of birth: Activate to sort"]/input at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. (I'm sorting out Cypress issues also check them) Ha, I think it's where I left this bug and why I was asking comment 5. There is the sorting arrows not correctly displayed in the headers, and the class is no longer on the the but in a span child. https://snipboard.io/olhaYc.jpg Created attachment 190614 [details] [review] Bug 40816: (follow-up) Standardize sort icon alignment DataTables wants to change the alignment of the sorting icons when it detects the column contents as numeric or date. This patch overrides that. Created attachment 190615 [details] [review] Bug 40816: Fix a failing Selenium test Patch from commit 3040a99 Thanks for the fix :) (In reply to Victor Grousset/tuxayo from comment #22) > (I'm sorting out Cypress issues also check them) Finally! Unfortunately there are 3 tests that fails with the patches: cypress run --config video=false --spec "t/cypress/integration/Tools/ManageMarcImport_spec.ts,t/cypress/integration/Auth/csrf.ts,t/cypress/integration/ERM/Agreements_spec.ts" ------------- 1) loads the manage MARC import page upload a MARC record: AssertionError: Timed out retrying after 10000ms: Expected to find content: 'View batch' but never did. at Context.eval (webpack://koha/./t/cypress/integration/Tools/ManageMarcImport_spec.ts:75:11) ---------------- 1) CSRF Add: AssertionError: Timed out retrying after 10000ms: Expected to find element: `select[name='libraries_length']`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Auth/csrf.ts:112:11) -------------------- 1) Agreement CRUD operations Delete agreement: Error: The following error originated from your application code, not from Cypress. > ResizeObserver loop limit exceeded When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. https://on.cypress.io/uncaught-exception-from-application at <unknown> (http://koha:8081/cgi-bin/koha/erm/agreements:0:0) QA script complains about koha-tmpl/opac-tmpl/lib/datatables/datatables.min.js but it shouldn't be checked so it's a false positive. Since it's only checked when being touched by a commit, that doesn't seem to an issue even if left as is. Created attachment 190937 [details] [review] Bug 40816: Fix Auth/csrf.ts Patch from commit b69cdec Created attachment 190938 [details] [review] Bug 40816: Ignore 'ResizeObserver loop limit exceeded' I have NO idea how to fix this error. I don't see it on the Koha UI, neither using Cypress UI. It seems safe for now to ignore this error (The internet says so). (In reply to Victor Grousset/tuxayo from comment #26) > cypress run --config video=false --spec > "t/cypress/integration/Tools/ManageMarcImport_spec.ts,t/cypress/integration/ > Auth/csrf.ts,t/cypress/integration/ERM/Agreements_spec.ts" > > ------------- > 1) loads the manage MARC import page > upload a MARC record: > AssertionError: Timed out retrying after 10000ms: Expected to find > content: 'View batch' but never did. > at Context.eval > (webpack://koha/./t/cypress/integration/Tools/ManageMarcImport_spec.ts:75:11) Known random failure, see bug 41368. > 1) CSRF > Add: > AssertionError: Timed out retrying after 10000ms: Expected to find > element: `select[name='libraries_length']`, but never found it. > at Context.eval > (webpack://koha/./t/cypress/integration/Auth/csrf.ts:112:11) Should be fixed. > 1) Agreement CRUD operations > Delete agreement: > > Error: The following error originated from your application code, not > from Cypress. > > > ResizeObserver loop limit exceeded > > When Cypress detects uncaught errors originating from your application it > will automatically fail the current test. > > This behavior is configurable, and you can choose to turn this off by > listening to the `uncaught:exception` event. > > https://on.cypress.io/uncaught-exception-from-application > at <unknown> (http://koha:8081/cgi-bin/koha/erm/agreements:0:0) I am stuck on this one, I've decided to ignore the error for now. |