| Summary: | Bookings related built CSS not ignored by Git | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | RESOLVED FIXED | QA Contact: | Paul Derscheid <paul.derscheid> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | aude.charillon, fridolin.somers, lucas, martin.renvoize, paul.derscheid, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
25.11.00,25.05.04
|
Circulation function: | |
| Bug Depends on: | 40656 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 40838: Add generated bookings CSS assets to gitignore
Bug 40838: Add generated bookings CSS assets to gitignore Bug 40838: Add generated bookings CSS assets to gitignore |
||
|
Description
Tomás Cohen Arazi (tcohen)
2025-09-18 14:01:34 UTC
Created attachment 186563 [details] [review] Bug 40838: Add generated bookings CSS assets to gitignore Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Created attachment 186564 [details] [review] Bug 40838: Add generated bookings CSS assets to gitignore To test: 1. Run: $ ktd --shell k$ yarn build 2. Run: k$ git status ``` On branch main Your branch is up to date with 'origin/main'. Untracked files: (use "git add <file>..." to include in what will be committed) .vstags koha-tmpl/intranet-tmpl/prog/css/bookings-rtl.css koha-tmpl/intranet-tmpl/prog/css/bookings.css nothing added to commit but untracked files present (use "git add" to track) ``` => FAIL: Bookings-related generated CSS show as untracked for git. 2. Apply this patch 3. Repeat 2 => SUCCESS: No untracked files 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Created attachment 186606 [details] [review] Bug 40838: Add generated bookings CSS assets to gitignore To test: 1. Run: $ ktd --shell k$ yarn build 2. Run: k$ git status ``` On branch main Your branch is up to date with 'origin/main'. Untracked files: (use "git add <file>..." to include in what will be committed) .vstags koha-tmpl/intranet-tmpl/prog/css/bookings-rtl.css koha-tmpl/intranet-tmpl/prog/css/bookings.css nothing added to commit but untracked files present (use "git add" to track) ``` => FAIL: Bookings-related generated CSS show as untracked for git. 2. Apply this patch 3. Repeat 2 => SUCCESS: No untracked files 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Trivial. PQA. My bad, forgot that there's actually new css going to be emitted. Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x No update to the Koha Manual needed. |