I think it was bug 40656 that introduced bookings.scss, and now we have: ```shell $ git status En la rama main Tu rama está actualizada con 'origin/main'. Archivos sin seguimiento: (usa "git add <archivo>..." para incluirlo a lo que será confirmado) koha-tmpl/intranet-tmpl/prog/css/bookings-rtl.css koha-tmpl/intranet-tmpl/prog/css/bookings.css ``` It's in spanish, but you get the point.
Created attachment 186563 [details] [review] Bug 40838: Add generated bookings CSS assets to gitignore Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Created attachment 186564 [details] [review] Bug 40838: Add generated bookings CSS assets to gitignore To test: 1. Run: $ ktd --shell k$ yarn build 2. Run: k$ git status ``` On branch main Your branch is up to date with 'origin/main'. Untracked files: (use "git add <file>..." to include in what will be committed) .vstags koha-tmpl/intranet-tmpl/prog/css/bookings-rtl.css koha-tmpl/intranet-tmpl/prog/css/bookings.css nothing added to commit but untracked files present (use "git add" to track) ``` => FAIL: Bookings-related generated CSS show as untracked for git. 2. Apply this patch 3. Repeat 2 => SUCCESS: No untracked files 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Created attachment 186606 [details] [review] Bug 40838: Add generated bookings CSS assets to gitignore To test: 1. Run: $ ktd --shell k$ yarn build 2. Run: k$ git status ``` On branch main Your branch is up to date with 'origin/main'. Untracked files: (use "git add <file>..." to include in what will be committed) .vstags koha-tmpl/intranet-tmpl/prog/css/bookings-rtl.css koha-tmpl/intranet-tmpl/prog/css/bookings.css nothing added to commit but untracked files present (use "git add" to track) ``` => FAIL: Bookings-related generated CSS show as untracked for git. 2. Apply this patch 3. Repeat 2 => SUCCESS: No untracked files 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Trivial. PQA. My bad, forgot that there's actually new css going to be emitted.
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Depends on Bug 40656 not in 24.11.x
No update to the Koha Manual needed.