Bug 40838 - Bookings related built CSS not ignored by Git
Summary: Bookings related built CSS not ignored by Git
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 40656
Blocks:
  Show dependency treegraph
 
Reported: 2025-09-18 14:01 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-09-18 14:08 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40838: Add generated bookings CSS assets to gitignore (961 bytes, patch)
2025-09-18 14:03 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 40838: Add generated bookings CSS assets to gitignore (1.48 KB, patch)
2025-09-18 14:08 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2025-09-18 14:01:34 UTC
I think it was bug 40656 that introduced bookings.scss, and now we have:

```shell
$ git status
En la rama main
Tu rama está actualizada con 'origin/main'.

Archivos sin seguimiento:
  (usa "git add <archivo>..." para incluirlo a lo que será confirmado)
        koha-tmpl/intranet-tmpl/prog/css/bookings-rtl.css
        koha-tmpl/intranet-tmpl/prog/css/bookings.css
```

It's in spanish, but you get the point.
Comment 1 Tomás Cohen Arazi (tcohen) 2025-09-18 14:03:22 UTC
Created attachment 186563 [details] [review]
Bug 40838: Add generated bookings CSS assets to gitignore

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi (tcohen) 2025-09-18 14:08:18 UTC
Created attachment 186564 [details] [review]
Bug 40838: Add generated bookings CSS assets to gitignore

To test:
1. Run:
   $ ktd --shell
  k$ yarn build
2. Run:
  k$ git status
```
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	.vstags
	koha-tmpl/intranet-tmpl/prog/css/bookings-rtl.css
	koha-tmpl/intranet-tmpl/prog/css/bookings.css

nothing added to commit but untracked files present (use "git add" to track)
```
=> FAIL: Bookings-related generated CSS show as untracked for git.
2. Apply this patch
3. Repeat 2
=> SUCCESS: No untracked files
4. Sign off :-D

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>