| Summary: | Uneven field lengths in additem.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Cataloging | Assignee: | Laura Escamilla <Laura.escamilla> |
| Status: | Needs documenting --- | QA Contact: | Paul Derscheid <paul.derscheid> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | baptiste.wojtkowski, carthur, Chip.Halvorsen, cj.lynce, dcook, fridolin.somers, gmcharlt, karie.straube, kyle, Laura.escamilla, m.de.rooy, paul.derscheid |
| Version: | Main | Keywords: | release-notes-needed |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.05
|
|
| Circulation function: | |||
| Attachments: |
Example
Bug 40897: Resized the field lengths to ensure even lengths Bug 40897: Resized the field lengths to ensure even lengths Bug 40897: Resized the field lengths to ensure even lengths |
||
Created attachment 187142 [details] [review] Bug 40897: Resized the field lengths to ensure even lengths To test: 1. Select an existing record and manage items (or create a new record) so that you are on the additem.pl form. 2. Notice that the fields are uneven lengths. 3. Apply the patch. Do a yarn build and restart_all. Clear your browser cache if necessary. 4. Refresh the additem.pl page and notice that the fields are all the same length now. 5. Sign off and have a great day! Created attachment 187224 [details] [review] Bug 40897: Resized the field lengths to ensure even lengths To test: 1. Select an existing record and manage items (or create a new record) so that you are on the additem.pl form. 2. Notice that the fields are uneven lengths. 3. Apply the patch. Do a yarn build and restart_all. Clear your browser cache if necessary. 4. Refresh the additem.pl page and notice that the fields are all the same length now. 5. Sign off and have a great day! Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Created attachment 187247 [details] [review] Bug 40897: Resized the field lengths to ensure even lengths To test: 1. Select an existing record and manage items (or create a new record) so that you are on the additem.pl form. 2. Notice that the fields are uneven lengths. 3. Apply the patch. Do a yarn build and restart_all. Clear your browser cache if necessary. 4. Refresh the additem.pl page and notice that the fields are all the same length now. 5. Sign off and have a great day! Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> This is great! Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Hey Frido, did you intentionally add this to 24.11? I'm seeing it in 24.11.11 and it's made the additem.pl fields look uneven? I'm guessing that this should've depended on a bug relating to select2 field lengths... (In reply to David Cook from comment #8) > I'm guessing that this should've depended on a bug relating to select2 field > lengths... Looks like probably bug 39533 and it's followups (In reply to David Cook from comment #7) > Hey Frido, did you intentionally add this to 24.11? I'm seeing it in > 24.11.11 and it's made the additem.pl fields look uneven? Oups indeed I see it in v24.11.11-1 : https://git.koha-community.org/Koha-community/Koha/commit/bdafea91e586e78af93fca9bef282d1198159141 I revert for v24.11.12-1 Intentionnaly reverted, will not be reapplied |
Created attachment 187036 [details] Example IF you look at the additem form on additem.tt the input lengths are not the same width. Fields with select2 dropdowns are longer than those without.