Bug 40897 - Uneven field lengths in additem.tt
Summary: Uneven field lengths in additem.tt
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Laura Escamilla
QA Contact: Paul Derscheid
URL:
Keywords: release-notes-needed
Depends on:
Blocks:
 
Reported: 2025-09-29 12:59 UTC by Lucas Gass (lukeg)
Modified: 2026-01-20 14:40 UTC (History)
12 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.05
Circulation function:


Attachments
Example (61.74 KB, image/png)
2025-09-29 12:59 UTC, Lucas Gass (lukeg)
Details
Bug 40897: Resized the field lengths to ensure even lengths (1.65 KB, patch)
2025-09-30 21:09 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 40897: Resized the field lengths to ensure even lengths (1.70 KB, patch)
2025-10-01 19:58 UTC, CJ Lynce
Details | Diff | Splinter Review
Bug 40897: Resized the field lengths to ensure even lengths (1.76 KB, patch)
2025-10-02 10:01 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-09-29 12:59:40 UTC
Created attachment 187036 [details]
Example

IF you look at the additem form on additem.tt the input lengths are not the same width. Fields with select2 dropdowns are longer than those without.
Comment 1 Laura Escamilla 2025-09-30 21:09:26 UTC
Created attachment 187142 [details] [review]
Bug 40897: Resized the field lengths to ensure even lengths

To test:
1. Select an existing record and manage items (or create a new record) so that you are on the additem.pl form.
2. Notice that the fields are uneven lengths.
3. Apply the patch. Do a yarn build and restart_all. Clear your browser cache if necessary.
4. Refresh the additem.pl page and notice that the fields are all the same length now.
5. Sign off and have a great day!
Comment 2 CJ Lynce 2025-10-01 19:58:08 UTC
Created attachment 187224 [details] [review]
Bug 40897: Resized the field lengths to ensure even lengths

To test:
1. Select an existing record and manage items (or create a new record) so that you are on the additem.pl form.
2. Notice that the fields are uneven lengths.
3. Apply the patch. Do a yarn build and restart_all. Clear your browser cache if necessary.
4. Refresh the additem.pl page and notice that the fields are all the same length now.
5. Sign off and have a great day!

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Comment 3 Paul Derscheid 2025-10-02 10:01:56 UTC
Created attachment 187247 [details] [review]
Bug 40897: Resized the field lengths to ensure even lengths

To test:
1. Select an existing record and manage items (or create a new record) so that you are on the additem.pl form.
2. Notice that the fields are uneven lengths.
3. Apply the patch. Do a yarn build and restart_all. Clear your browser cache if necessary.
4. Refresh the additem.pl page and notice that the fields are all the same length now.
5. Sign off and have a great day!

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 4 Paul Derscheid 2025-10-02 10:05:58 UTC
This is great!
Comment 5 Lucas Gass (lukeg) 2025-10-06 15:17:00 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Paul Derscheid 2025-10-23 21:11:25 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 7 David Cook 2026-01-20 02:22:25 UTC
Hey Frido, did you intentionally add this to 24.11? I'm seeing it in 24.11.11 and it's made the additem.pl fields look uneven?
Comment 8 David Cook 2026-01-20 02:23:22 UTC
I'm guessing that this should've depended on a bug relating to select2 field lengths...
Comment 9 David Cook 2026-01-20 02:44:28 UTC
(In reply to David Cook from comment #8)
> I'm guessing that this should've depended on a bug relating to select2 field
> lengths...

Looks like probably bug 39533 and it's followups
Comment 10 Fridolin Somers 2026-01-20 08:42:54 UTC
(In reply to David Cook from comment #7)
> Hey Frido, did you intentionally add this to 24.11? I'm seeing it in
> 24.11.11 and it's made the additem.pl fields look uneven?

Oups indeed I see it in v24.11.11-1 :

https://git.koha-community.org/Koha-community/Koha/commit/bdafea91e586e78af93fca9bef282d1198159141

I revert for v24.11.12-1
Comment 11 Baptiste Wojtkowski (bwoj) 2026-01-20 14:40:46 UTC
Intentionnaly reverted, will not be reapplied