|
Description
Jonathan Druart
2025-10-03 10:13:14 UTC
I suggest to Change position of Ordering information with Contact. Then the contacts Table could have the full width of the screen And ordering information should be on top of the page because they are required, as contacts are optional. Then this would be the order of the sections: Details (left column) Order Ordering information (right column) Aliases (left column) Interfaces (right column) Contacts Contracts Created attachment 188360 [details] [review] Bug 40942: Improve the display of vendor contracts Test plan: 1) Apply patch and yarn js:build 2) Navigate to a vendor and add some contacts 3) View the vendor record 4) The contacts table should now be at the bottom of the page and the full width of the screen 5) The Ordering information section should be at the top right of the screen Created attachment 188367 [details] [review] Bug 40942: Account for the order of split panes in split screen view Created attachment 188368 [details] [review] Bug 40942: Improve the display of vendor contracts Test plan: 1) Apply patch and yarn js:build 2) Navigate to a vendor and add some contacts 3) View the vendor record 4) The contacts table should now be at the bottom of the page and the full width of the screen 5) The Ordering information section should be at the top right of the screen Signed-off-by: Michaela <michaela.sieber@kit.edu> Created attachment 188369 [details] [review] Bug 40942: Account for the order of split panes in split screen view Signed-off-by: Michaela <michaela.sieber@kit.edu> Created attachment 188663 [details] [review] Bug 40942: Improve the display of vendor contracts Test plan: 1) Apply patch and yarn js:build 2) Navigate to a vendor and add some contacts 3) View the vendor record 4) The contacts table should now be at the bottom of the page and the full width of the screen 5) The Ordering information section should be at the top right of the screen Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 188664 [details] [review] Bug 40942: Account for the order of split panes in split screen view Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Nice work everyone! Pushed to main for 25.11 This broke VueFramework_spec.ts AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Contracts' within the element: <fieldset.rows> but never did. Created attachment 189534 [details] [review] Bug 40942: Hide the 'Contacts' block if nothing to display If there is no contact we should hide the "Contacts" block on the "show" view. Fixes VueFramework_spec.ts AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Contracts' within the element: <fieldset.rows> but never did. I think this patch correctly fixes the failing test. The display of contacts and contracts is inconsistent however: https://snipboard.io/47EDBj.jpg |