Bug 40942 - Vendor's contacts not displayed nicely on the vendor detail view
Summary: Vendor's contacts not displayed nicely on the vendor detail view
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Matt Blenkinsop
QA Contact: Laura Escamilla
URL:
Keywords: additional_work_needed
Depends on: 38201
Blocks:
  Show dependency treegraph
 
Reported: 2025-10-03 10:13 UTC by Jonathan Druart
Modified: 2025-11-13 09:17 UTC (History)
7 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40942: Improve the display of vendor contracts (7.74 KB, patch)
2025-10-23 13:58 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 40942: Account for the order of split panes in split screen view (1.46 KB, patch)
2025-10-23 14:52 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 40942: Improve the display of vendor contracts (7.79 KB, patch)
2025-10-23 15:10 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 40942: Account for the order of split panes in split screen view (1.50 KB, patch)
2025-10-23 15:11 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 40942: Improve the display of vendor contracts (7.86 KB, patch)
2025-10-30 15:39 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 40942: Account for the order of split panes in split screen view (1.57 KB, patch)
2025-10-30 15:39 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 40942: Hide the 'Contacts' block if nothing to display (1.26 KB, patch)
2025-11-13 09:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-10-03 10:13:14 UTC
The table is too wide, or not positioned correctly.

https://snipboard.io/eUNGQ1.jpg
Comment 1 Michaela Sieber 2025-10-23 07:43:57 UTC
I suggest to
Change position of Ordering information with Contact. Then the contacts Table could have the full width of the screen
And ordering information should be on top of the page because they are required, as contacts are optional.

Then this would be the order of the sections:

Details (left column) 
Order Ordering information (right column)
Aliases  (left column) 
Interfaces (right column)

Contacts

Contracts
Comment 2 Matt Blenkinsop 2025-10-23 13:58:23 UTC
Created attachment 188360 [details] [review]
Bug 40942: Improve the display of vendor contracts

Test plan:
1) Apply patch and yarn js:build
2) Navigate to a vendor and add some contacts
3) View the vendor record
4) The contacts table should now be at the bottom of the page and the full width of the screen
5) The Ordering information section should be at the top right of the screen
Comment 3 Matt Blenkinsop 2025-10-23 14:52:49 UTC
Created attachment 188367 [details] [review]
Bug 40942: Account for the order of split panes in split screen view
Comment 4 Biblibre Sandboxes 2025-10-23 15:10:59 UTC
Created attachment 188368 [details] [review]
Bug 40942: Improve the display of vendor contracts

Test plan:
1) Apply patch and yarn js:build
2) Navigate to a vendor and add some contacts
3) View the vendor record
4) The contacts table should now be at the bottom of the page and the full width of the screen
5) The Ordering information section should be at the top right of the screen

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Comment 5 Biblibre Sandboxes 2025-10-23 15:11:02 UTC
Created attachment 188369 [details] [review]
Bug 40942: Account for the order of split panes in split screen view

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Comment 6 Laura Escamilla 2025-10-30 15:39:16 UTC
Created attachment 188663 [details] [review]
Bug 40942: Improve the display of vendor contracts

Test plan:
1) Apply patch and yarn js:build
2) Navigate to a vendor and add some contacts
3) View the vendor record
4) The contacts table should now be at the bottom of the page and the full width of the screen
5) The Ordering information section should be at the top right of the screen

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 7 Laura Escamilla 2025-10-30 15:39:23 UTC
Created attachment 188664 [details] [review]
Bug 40942: Account for the order of split panes in split screen view

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 8 Lucas Gass (lukeg) 2025-11-03 21:16:35 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 9 Jonathan Druart 2025-11-13 08:57:51 UTC
This broke VueFramework_spec.ts

AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Contracts' within the element: <fieldset.rows> but never did.
Comment 10 Jonathan Druart 2025-11-13 09:08:05 UTC
Created attachment 189534 [details] [review]
Bug 40942: Hide the 'Contacts' block if nothing to display

If there is no contact we should hide the "Contacts" block on the "show"
view.

Fixes VueFramework_spec.ts
AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Contracts' within the element: <fieldset.rows> but never did.
Comment 11 Jonathan Druart 2025-11-13 09:15:03 UTC
I think this patch correctly fixes the failing test.
Comment 12 Jonathan Druart 2025-11-13 09:17:21 UTC
The display of contacts and contracts is inconsistent however: https://snipboard.io/47EDBj.jpg