| Summary: | LOC classification display broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | MARC Bibliographic data support | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | Pushed to oldstable --- | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, lucas, nick, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the display logic for the Library of Congress classification field (050) in the staff interface for MARC21. The separator was being shown between subfields $a and $b, instead of between additional 050 entries.
Example:
For an 050 with two entries:
050 4 $aE337.5 $b.O54 2025
050 4 $aE415.7 $b.A44 2025
This was incorrectly shown in the staff interface as:
LOC classification: E337.5 | .O54 2025 E415.7 | .A44 2025
It should have been shown as:
LOC classification: E337.5 O54 2025 | E415.7 A44 2025
|
Version(s) released in: |
25.11.00,25.05.05,24.11.11
|
| Circulation function: | |||
| Bug Depends on: | 23731 | ||
| Bug Blocks: | 30148 | ||
| Attachments: |
Bug 40959: Fix LOC classification display (staff interface)
Bug 40959: Fix LOC classification display (staff interface) Bug 40959: Fix LOC classification display (staff interface) |
||
|
Description
Tomás Cohen Arazi (tcohen)
2025-10-06 13:53:41 UTC
Created attachment 187481 [details] [review] Bug 40959: Fix LOC classification display (staff interface) This patch fixes the display logic for the LOC classification field (050). The current issue is that the inner components (each subfield) gets separated with the pipe symbol (|) instead of grouping the components together and using the separator for the outer 050 occurences. To test: 1. Open a record to edit it 2. Add 050 like this: ``` 050 4 $aE337.5 $b.O54 2025 050 4 $aE415.7 $b.A44 2025 ``` 3. Save => FAIL On the staff interface it displays: ``` LOC classification: E337.5 | .O54 2025 E415.7 | .A44 2025 ``` 4. Apply this patch 5. Run: $ ktd --shell k$ restart_all 6. Reload the detail page => SUCCESS: Things display correctly! 7. Sign off :-D Created attachment 187496 [details] [review] Bug 40959: Fix LOC classification display (staff interface) This patch fixes the display logic for the LOC classification field (050). The current issue is that the inner components (each subfield) gets separated with the pipe symbol (|) instead of grouping the components together and using the separator for the outer 050 occurences. To test: 1. Open a record to edit it 2. Add 050 like this: ``` 050 4 $aE337.5 $b.O54 2025 050 4 $aE415.7 $b.A44 2025 ``` 3. Save => FAIL On the staff interface it displays: ``` LOC classification: E337.5 | .O54 2025 E415.7 | .A44 2025 ``` 4. Apply this patch 5. Run: $ ktd --shell k$ restart_all 6. Reload the detail page => SUCCESS: Things display correctly! 7. Sign off :-D Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 188036 [details] [review] Bug 40959: Fix LOC classification display (staff interface) This patch fixes the display logic for the LOC classification field (050). The current issue is that the inner components (each subfield) gets separated with the pipe symbol (|) instead of grouping the components together and using the separator for the outer 050 occurences. To test: 1. Open a record to edit it 2. Add 050 like this: ``` 050 4 $aE337.5 $b.O54 2025 050 4 $aE415.7 $b.A44 2025 ``` 3. Save => FAIL On the staff interface it displays: ``` LOC classification: E337.5 | .O54 2025 E415.7 | .A44 2025 ``` 4. Apply this patch 5. Run: $ ktd --shell k$ restart_all 6. Reload the detail page => SUCCESS: Things display correctly! 7. Sign off :-D Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.11 |