Bug 40985

Summary: Clarify POD of Holds->filter_by_found
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Hold requestsAssignee: Marcel de Rooy <m.de.rooy>
Status: Pushed to oldstable --- QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, gmcharlt, lisette, lucas, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.05,24.11.11
Circulation function:
Attachments: Bug 40985: Clarify POD of Holds->filter_by_found

Description Marcel de Rooy 2025-10-09 13:21:40 UTC
Most people read the following as contradictory:

POD Returns a filtered resultset without holds that are considered I<found>.
CODE return $self->search( { found => [ 'P', 'T', 'W' ] } );
Comment 1 Marcel de Rooy 2025-10-09 13:24:14 UTC
Created attachment 187661 [details] [review]
Bug 40985: Clarify POD of Holds->filter_by_found

Test plan:
Read POD.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2025-10-09 13:24:39 UTC
Self SO
Comment 3 Marcel de Rooy 2025-10-09 13:26:22 UTC
Unless RM disagrees, doing QA too now :)
Comment 4 Tomás Cohen Arazi (tcohen) 2025-10-09 15:11:32 UTC
PQA from me. Thanks for fixing it.
Comment 5 Lucas Gass (lukeg) 2025-10-09 21:03:36 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Paul Derscheid 2025-10-29 09:10:27 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 7 Fridolin Somers 2025-11-10 14:01:11 UTC
Pushed to 24.11.x for 24.11.11