Bug 41043

Summary: Use op 'add_form' and 'edit_form' instead of 'add' and 'edit'
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Architecture, internals, and plumbingAssignee: Fridolin Somers <fridolin.somers>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers

Description Fridolin Somers 2025-10-17 09:24:24 UTC
Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/oai_servers.pl and admin/z3950servers.pl
Comment 1 Fridolin Somers 2025-10-17 10:02:53 UTC
Created attachment 188057 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/z3950servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new z3950 server
2) Enter mandatory datas in form and save
3) Edit this server
4) Copy this server
5) Repeat 1 to 4 for a SRU server
Comment 2 Fridolin Somers 2025-10-17 10:03:36 UTC
Created attachment 188058 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/oai_servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new OAI repository
2) Enter mandatory datas in form and save
3) Edit this repository
4) Copy this repository
Comment 3 Fridolin Somers 2025-10-17 10:03:38 UTC
Created attachment 188059 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/z3950servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new z3950 server
2) Enter mandatory datas in form and save
3) Edit this server
4) Copy this server
5) Repeat 1 to 4 for a SRU server
Comment 4 David Nind 2025-11-28 03:57:57 UTC
Created attachment 190003 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/oai_servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new OAI repository
2) Enter mandatory datas in form and save
3) Edit this repository
4) Copy this repository

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-11-28 03:58:00 UTC
Created attachment 190004 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/z3950servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new z3950 server
2) Enter mandatory datas in form and save
3) Edit this server
4) Copy this server
5) Repeat 1 to 4 for a SRU server

Signed-off-by: David Nind <david@davidnind.com>