Bug 41043 - Use op 'add_form' and 'edit_form' instead of 'add' and 'edit'
Summary: Use op 'add_form' and 'edit_form' instead of 'add' and 'edit'
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-17 09:24 UTC by Fridolin Somers
Modified: 2026-01-30 17:02 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers (7.71 KB, patch)
2025-10-17 10:02 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers (6.88 KB, patch)
2025-10-17 10:03 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers (7.71 KB, patch)
2025-10-17 10:03 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers (6.92 KB, patch)
2025-11-28 03:57 UTC, David Nind
Details | Diff | Splinter Review
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers (7.75 KB, patch)
2025-11-28 03:58 UTC, David Nind
Details | Diff | Splinter Review
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers (7.00 KB, patch)
2026-01-30 17:02 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers (7.83 KB, patch)
2026-01-30 17:02 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2025-10-17 09:24:24 UTC
Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/oai_servers.pl and admin/z3950servers.pl
Comment 1 Fridolin Somers 2025-10-17 10:02:53 UTC
Created attachment 188057 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/z3950servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new z3950 server
2) Enter mandatory datas in form and save
3) Edit this server
4) Copy this server
5) Repeat 1 to 4 for a SRU server
Comment 2 Fridolin Somers 2025-10-17 10:03:36 UTC
Created attachment 188058 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/oai_servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new OAI repository
2) Enter mandatory datas in form and save
3) Edit this repository
4) Copy this repository
Comment 3 Fridolin Somers 2025-10-17 10:03:38 UTC
Created attachment 188059 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/z3950servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new z3950 server
2) Enter mandatory datas in form and save
3) Edit this server
4) Copy this server
5) Repeat 1 to 4 for a SRU server
Comment 4 David Nind 2025-11-28 03:57:57 UTC
Created attachment 190003 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/oai_servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new OAI repository
2) Enter mandatory datas in form and save
3) Edit this repository
4) Copy this repository

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-11-28 03:58:00 UTC
Created attachment 190004 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/z3950servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new z3950 server
2) Enter mandatory datas in form and save
3) Edit this server
4) Copy this server
5) Repeat 1 to 4 for a SRU server

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Kyle M Hall (khall) 2026-01-30 17:02:17 UTC
Created attachment 192253 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in oai servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/oai_servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new OAI repository
2) Enter mandatory datas in form and save
3) Edit this repository
4) Copy this repository

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Kyle M Hall (khall) 2026-01-30 17:02:19 UTC
Created attachment 192254 [details] [review]
Bug 41043: Use op 'add_form' and 'edit_form' in z3950 servers

Since CSRF protection, 'op' arg for creating/editing an object uses add_form and edit_form.
This is missing only in admin/z3950servers.pl

This patch also removes TT variable add_form to avoid confusion

Test plan :
1) Create a new z3950 server
2) Enter mandatory datas in form and save
3) Edit this server
4) Copy this server
5) Repeat 1 to 4 for a SRU server

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>