Bug 41057

Summary: OPAC ILL visiting a URL directly does not respect ILLOpacbackends
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Pushed to main --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: katrin.fischer, lisette, m.de.rooy, n.halford-busby, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Crowdfunding goal: 0
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:
Attachments: Bug 41057: Return 404 if creating backend is not an OPAC backend
[24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
[24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
[24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
[24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
Bug 41057: Return 404 if creating backend is not an OPAC backend
Bug 41057: Return 404 if creating backend is not an OPAC backend

Description Pedro Amorim 2025-10-20 15:27:53 UTC

    
Comment 1 Pedro Amorim 2025-10-20 15:33:35 UTC
Created attachment 188170 [details] [review]
Bug 41057: Return 404 if creating backend is not an OPAC backend

Test plan, ktd:
1) Enable ILLModule
2) Install an additional backend plugin e.g. 'RapidILL':
  https://github.com/openfifth/koha-ill-rapidill/releases/tag/v2.2.5
3) Restart plack if you have to:
$ koha-plack --restart kohadev
4) Edit the ILLOpacbackends system preference to just 'Standard'.
5) Now, attempt to create a request with the installed backend directly:
  <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=RapidILL
6) Notice the form is shown. It shouldn't be, as the only OPAC back is Standard.
7) Apply patch. Repeat. You get a 404.
Comment 2 Pedro Amorim 2025-10-20 15:47:42 UTC
Created attachment 188171 [details] [review]
[24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
Comment 3 Pedro Amorim 2025-10-23 10:39:46 UTC
Created attachment 188320 [details] [review]
[24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
Comment 4 Pedro Amorim 2025-10-23 10:48:21 UTC
Created attachment 188322 [details] [review]
[24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
Comment 5 Pedro Amorim 2025-10-23 10:50:50 UTC
Created attachment 188323 [details] [review]
[24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend

Signed-off-by: Nial Halford-Busby <n.halford-busby@lboro.ac.uk>
Comment 6 Pedro Amorim 2025-10-23 11:02:03 UTC
Created attachment 188325 [details] [review]
Bug 41057: Return 404 if creating backend is not an OPAC backend

Test plan, ktd:
1) Enable ILLModule
2) Install an additional backend plugin e.g. 'RapidILL':
  https://github.com/openfifth/koha-ill-rapidill/releases/tag/v2.2.5
3) Restart plack if you have to:
$ koha-plack --restart kohadev
4) Edit the ILLOpacbackends system preference to just 'Standard'.
5) Now, attempt to create a request with the installed backend directly:
  <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=RapidILL
6) Notice the form is shown. It shouldn't be, as the only OPAC back is Standard.
7) Apply patch. Repeat. You get a 404.

Signed-off-by: Nial Halford-Busby <n.halford-busby@lboro.ac.uk>
Comment 7 Marcel de Rooy 2025-10-24 07:14:42 UTC
Created attachment 188400 [details] [review]
Bug 41057: Return 404 if creating backend is not an OPAC backend

Test plan, ktd:
1) Enable ILLModule
2) Install an additional backend plugin e.g. 'RapidILL':
  https://github.com/openfifth/koha-ill-rapidill/releases/tag/v2.2.5
3) Restart plack if you have to:
$ koha-plack --restart kohadev
4) Edit the ILLOpacbackends system preference to just 'Standard'.
5) Now, attempt to create a request with the installed backend directly:
  <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=RapidILL
6) Notice the form is shown. It shouldn't be, as the only OPAC back is Standard.
7) Apply patch. Repeat. You get a 404.

Signed-off-by: Nial Halford-Busby <n.halford-busby@lboro.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Lucas Gass (lukeg) 2025-10-24 13:59:08 UTC
Nice work everyone!

Pushed to main for 25.11