Created attachment 188170 [details] [review] Bug 41057: Return 404 if creating backend is not an OPAC backend Test plan, ktd: 1) Enable ILLModule 2) Install an additional backend plugin e.g. 'RapidILL': https://github.com/openfifth/koha-ill-rapidill/releases/tag/v2.2.5 3) Restart plack if you have to: $ koha-plack --restart kohadev 4) Edit the ILLOpacbackends system preference to just 'Standard'. 5) Now, attempt to create a request with the installed backend directly: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=RapidILL 6) Notice the form is shown. It shouldn't be, as the only OPAC back is Standard. 7) Apply patch. Repeat. You get a 404.
Created attachment 188171 [details] [review] [24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
Created attachment 188320 [details] [review] [24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
Created attachment 188322 [details] [review] [24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend
Created attachment 188323 [details] [review] [24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend Signed-off-by: Nial Halford-Busby <n.halford-busby@lboro.ac.uk>
Created attachment 188325 [details] [review] Bug 41057: Return 404 if creating backend is not an OPAC backend Test plan, ktd: 1) Enable ILLModule 2) Install an additional backend plugin e.g. 'RapidILL': https://github.com/openfifth/koha-ill-rapidill/releases/tag/v2.2.5 3) Restart plack if you have to: $ koha-plack --restart kohadev 4) Edit the ILLOpacbackends system preference to just 'Standard'. 5) Now, attempt to create a request with the installed backend directly: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=RapidILL 6) Notice the form is shown. It shouldn't be, as the only OPAC back is Standard. 7) Apply patch. Repeat. You get a 404. Signed-off-by: Nial Halford-Busby <n.halford-busby@lboro.ac.uk>
Created attachment 188400 [details] [review] Bug 41057: Return 404 if creating backend is not an OPAC backend Test plan, ktd: 1) Enable ILLModule 2) Install an additional backend plugin e.g. 'RapidILL': https://github.com/openfifth/koha-ill-rapidill/releases/tag/v2.2.5 3) Restart plack if you have to: $ koha-plack --restart kohadev 4) Edit the ILLOpacbackends system preference to just 'Standard'. 5) Now, attempt to create a request with the installed backend directly: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=RapidILL 6) Notice the form is shown. It shouldn't be, as the only OPAC back is Standard. 7) Apply patch. Repeat. You get a 404. Signed-off-by: Nial Halford-Busby <n.halford-busby@lboro.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Created attachment 189165 [details] [review] [24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend Signed-off-by: Nial Halford-Busby <n.halford-busby@lboro.ac.uk>
(In reply to Pedro Amorim from comment #10) > Created attachment 189165 [details] [review] [review] > [24.11] Bug 41057: Return 404 if creating backend is not an OPAC backend > > Signed-off-by: Nial Halford-Busby <n.halford-busby@lboro.ac.uk> Updated 24.11 patch to include fix from bug 41204 since it's not yet been backported. Bug 41204 should only be pushed to 25.11.x and 25.05.x.
Pushed to 24.11.x for 24.11.11 Thanks a lot for the patch ;)