| Summary: | Some system preferences have target='blank' instead of target='_blank' | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Component: | System Administration | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Status: | Pushed to main --- | QA Contact: | David Nind <david> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, dcook, gmcharlt, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: |
This fixes the HTML target attribute for some system preference links that open a pop-up window or external link. The link attribute now uses "_blank" instead of "blank", and opens in a new tab for external links, and the same browser window for pop-up windows (modals).
|
|
| Version(s) released in: |
25.11.00
|
Circulation function: | |
| Attachments: |
Bug 41092: Some system preferences have target='blank' instead of target='_blank'
Bug 41092: Some system preferences have target='blank' instead of target='_blank' Bug 41092: Some system preferences have target='blank' instead of target='_blank' |
||
|
Description
Caroline Cyr La Rose
2025-10-23 18:59:47 UTC
Created attachment 188393 [details] [review] Bug 41092: Some system preferences have target='blank' instead of target='_blank' This patch changes target='blank' to target='_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields For reference, Paul D. sent me this stack overflow answer regarding the difference between blank and _blank. One will open all the clicks in the same tab (it will open a new tab the first time, but then identify that tab as "blank" and open all further clicks in that same one), whereas _blank will open always in a new tab. (... Is how I understand it!) https://stackoverflow.com/questions/36769460/is-the-underscore-in-target-blank-no-longer-needed Good catch. I recently noticed this somewhere in Koha as well I think... Created attachment 188413 [details] [review] Bug 41092: Some system preferences have target='blank' instead of target='_blank' This patch changes target='blank' to target='_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 188436 [details] [review] Bug 41092: Some system preferences have target='blank' instead of target='_blank' This patch changes target='blank' to target='_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Have changed to a minor bug, instead of an enhancement. QA script is happy. One thing I noticed, is that when you press "Save" for any changes in the pop-up windows, you get the notification "Saved preference XXXXX", but the "Save all XXX preferences" button in orange is still highlighted. Clicking that says "nothing to save". Outside the scope of this bug to fix that. According to Bugzilla no one wrote this patch and no one QA'd it? Fill out the Assignee and QA Contact fields please. (In reply to Lucas Gass (lukeg) from comment #7) > According to Bugzilla no one wrote this patch and no one QA'd it? > > Fill out the Assignee and QA Contact fields please. Fields updated. Nice work everyone! Pushed to main for 25.11 |