| Summary: | Click on data providers platform breaks functionality | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jan Kissig <bibliothek> |
| Component: | ERM | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
| Status: | Pushed to main --- | QA Contact: | Laura Escamilla <Laura.escamilla> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, jonathan.field, Laura.escamilla, martin.renvoize, matt.blenkinsop, michaela.sieber, pedro.amorim |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
25.11.00
|
Circulation function: | |
| Attachments: |
bug on console
Bug 41103: Remove incorrect use of table settings Bug 41103: Remove incorrect use of table settings Bug 41103: Remove incorrect use of table settings Bug 41103: Remove incorrect use of table settings |
||
The harvest report job says: Usage data provider Carl Hanser Verlag Report type PR Report rows processed 7 Platforms added 1 Monthly usages skipped 0 Monthly usages added 7 Yearly usages skipped 0 Yearly usages added 7 Carl Hanser Verlag GmbH & Co. KG successfully added So a platform report seems to be harvested and the source for the error has another reason. this seems to be a regression, as on 24.11 the feature works as intended We can confirm this bug in main Created attachment 188479 [details] [review] Bug 41103: Remove incorrect use of table settings The table settings for titles have been set by default even though the data type for this table is dynamic Test plan: 1) Create a provider and harvest some platform data 2) Click into the provider and select the Platform tab 3) The page will crash and the console will show an error 4) Apply patch and yarn js:build 5) Hard refresh the page and click on Platforms again 6) The table should load successfully Created attachment 188484 [details] [review] Bug 41103: Remove incorrect use of table settings The table settings for titles have been set by default even though the data type for this table is dynamic Test plan: 1) Create a provider and harvest some platform data 2) Click into the provider and select the Platform tab 3) The page will crash and the console will show an error 4) Apply patch and yarn js:build 5) Hard refresh the page and click on Platforms again 6) The table should load successfully Signed-off-by: Michaela <michaela.sieber@kit.edu> Thanks Matt! Created attachment 188486 [details] [review] Bug 41103: Remove incorrect use of table settings The table settings for titles have been set by default even though the data type for this table is dynamic Test plan: 1) Create a provider and harvest some platform data 2) Click into the provider and select the Platform tab 3) The page will crash and the console will show an error 4) Apply patch and yarn js:build 5) Hard refresh the page and click on Platforms again 6) The table should load successfully Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Created attachment 188659 [details] [review] Bug 41103: Remove incorrect use of table settings The table settings for titles have been set by default even though the data type for this table is dynamic Test plan: 1) Create a provider and harvest some platform data 2) Click into the provider and select the Platform tab 3) The page will crash and the console will show an error 4) Apply patch and yarn js:build 5) Hard refresh the page and click on Platforms again 6) The table should load successfully Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Nice work everyone! Pushed to main for 25.11 |
Created attachment 188441 [details] bug on console to recreate: - add a data provider to harvest sushi data in /cgi-bin/koha/erm/eusage/usage_data_providers - I used Hanser as it seems not to reply with a PR report !!! - add Report types: PR - perform a harvest - then go to /cgi-bin/koha/erm/eusage/usage_data_providers/<provider id> - open developer tools (F12 on Firefox) - click on Platforms - see error in console - any other click won't work in providers nav bar