Bug 41103 - Click on data providers platform breaks functionality
Summary: Click on data providers platform breaks functionality
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Matt Blenkinsop
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-25 18:23 UTC by Jan Kissig
Modified: 2025-10-31 21:32 UTC (History)
7 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
bug on console (180.44 KB, image/png)
2025-10-25 18:23 UTC, Jan Kissig
Details
Bug 41103: Remove incorrect use of table settings (1.38 KB, patch)
2025-10-27 16:23 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 41103: Remove incorrect use of table settings (1.43 KB, patch)
2025-10-27 16:38 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 41103: Remove incorrect use of table settings (1.48 KB, patch)
2025-10-27 18:42 UTC, Jan Kissig
Details | Diff | Splinter Review
Bug 41103: Remove incorrect use of table settings (1.54 KB, patch)
2025-10-30 14:26 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kissig 2025-10-25 18:23:12 UTC
Created attachment 188441 [details]
bug on console

to recreate:

- add a data provider to harvest sushi data in /cgi-bin/koha/erm/eusage/usage_data_providers
- I used Hanser as it seems not to reply with a PR report !!!
- add Report types: PR
- perform a harvest
- then go to /cgi-bin/koha/erm/eusage/usage_data_providers/<provider id>
- open developer tools (F12 on Firefox)
- click on Platforms
- see error in console
- any other click won't work in providers nav bar
Comment 1 Jan Kissig 2025-10-27 08:30:32 UTC
The harvest report job says:

Usage data provider 	Carl Hanser Verlag
Report type 	PR
Report rows processed 	7
Platforms added 	1
Monthly usages skipped 	0
Monthly usages added 	7
Yearly usages skipped 	0
Yearly usages added 	7

Carl Hanser Verlag GmbH & Co. KG successfully added 

So a platform report seems to be harvested and the source for the error has another reason.
Comment 2 Jan Kissig 2025-10-27 11:07:18 UTC
this seems to be a regression, as on 24.11 the feature works as intended
Comment 3 Michaela Sieber 2025-10-27 12:34:03 UTC
We can confirm this bug in main
Comment 4 Matt Blenkinsop 2025-10-27 16:23:35 UTC
Created attachment 188479 [details] [review]
Bug 41103: Remove incorrect use of table settings

The table settings for titles have been set by default even though the data type for this table is dynamic

Test plan:
1) Create a provider and harvest some platform data
2) Click into the provider and select the Platform tab
3) The page will crash and the console will show an error
4) Apply patch and yarn js:build
5) Hard refresh the page and click on Platforms again
6) The table should load successfully
Comment 5 Biblibre Sandboxes 2025-10-27 16:38:12 UTC
Created attachment 188484 [details] [review]
Bug 41103: Remove incorrect use of table settings

The table settings for titles have been set by default even though the data type for this table is dynamic

Test plan:
1) Create a provider and harvest some platform data
2) Click into the provider and select the Platform tab
3) The page will crash and the console will show an error
4) Apply patch and yarn js:build
5) Hard refresh the page and click on Platforms again
6) The table should load successfully

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Comment 6 Michaela Sieber 2025-10-27 16:39:11 UTC
Thanks Matt!
Comment 7 Jan Kissig 2025-10-27 18:42:17 UTC
Created attachment 188486 [details] [review]
Bug 41103: Remove incorrect use of table settings

The table settings for titles have been set by default even though the data type for this table is dynamic

Test plan:
1) Create a provider and harvest some platform data
2) Click into the provider and select the Platform tab
3) The page will crash and the console will show an error
4) Apply patch and yarn js:build
5) Hard refresh the page and click on Platforms again
6) The table should load successfully

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Comment 8 Laura Escamilla 2025-10-30 14:26:47 UTC
Created attachment 188659 [details] [review]
Bug 41103: Remove incorrect use of table settings

The table settings for titles have been set by default even though the data type for this table is dynamic

Test plan:
1) Create a provider and harvest some platform data
2) Click into the provider and select the Platform tab
3) The page will crash and the console will show an error
4) Apply patch and yarn js:build
5) Hard refresh the page and click on Platforms again
6) The table should load successfully

Signed-off-by: Michaela <michaela.sieber@kit.edu>
Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 9 Lucas Gass (lukeg) 2025-10-31 21:32:28 UTC
Nice work everyone!

Pushed to main for 25.11