| Summary: | Space is missing in report preview | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> | 
| Component: | Reports | Assignee: | David Nind <david> | 
| Status: | Pushed to main --- | QA Contact: | Brendan Lawlor <blawlor> | 
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | blawlor, david, lisette, lucas | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | String patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | 
       This fixes the 'Delete' button when previewing the SQL for a saved report - there is now a space between the trash can icon and Delete. 
 | 
        |
| Version(s) released in: | 
       25.11.00 
 | 
        
        Circulation function: | |
| Attachments: | 
              Bug 41112: Space is missing in report preview
               Bug 41112: Space is missing in report preview Bug 41112: Space is missing in report preview Bug 41112: Space is missing in report preview  | 
      ||
| 
 
        
          Description
        
        
          Baptiste Wojtkowski (bwoj)
        
        
        
        
          2025-10-27 16:32:10 UTC
        
       
    Created attachment 188482 [details] [review] Bug 41112: Space is missing in report preview No test plan needed. The change is too trivial. Just check that lines before in the code have the desired space. The missing space creates a weird sensation while looking at the window. Created attachment 188483 [details] [review] Bug 41112: Space is missing in report preview This patch puts back a missing space between "Delete" and the fa thrashcan. It is atm the lonely button without this space in the modal No test plan needed. The change is too trivial. Just check that lines before in the code have the desired space. The missing space creates a weird sensation while looking at the window. Created attachment 188509 [details] [review] Bug 41112: Space is missing in report preview This patch puts back a missing space between "Delete" and the fa thrashcan. It is atm the lonely button without this space in the modal No test plan needed. The change is too trivial. Just check that lines before in the code have the desired space. The missing space creates a weird sensation while looking at the window. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. In the reports module, create a report and save it. 2. From the saved reports list, select 'Preview SQL' from the dropdown list of actions. 3. Note that there is no space between the trash can icon and Delete. 4. Apply the patch. 5. Refresh the saved reports page. 6. Repeat step 2. 7. Note that there is now a space between the trash can icon and Delete, consistent with the other action buttons. Created attachment 188522 [details] [review] Bug 41112: Space is missing in report preview This patch puts back a missing space between "Delete" and the fa thrashcan. It is atm the lonely button without this space in the modal No test plan needed. The change is too trivial. Just check that lines before in the code have the desired space. The missing space creates a weird sensation while looking at the window. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Trivial fix. Passing QA. Nice work everyone! Pushed to main for 25.11  |