Bug 41112 - Space is missing in report preview
Summary: Space is missing in report preview
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: David Nind
QA Contact: Brendan Lawlor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-27 16:32 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-10-31 21:32 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the 'Delete' button when previewing the SQL for a saved report - there is now a space between the trash can icon and Delete.
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 41112: Space is missing in report preview (2.71 KB, patch)
2025-10-27 16:34 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 41112: Space is missing in report preview (2.85 KB, patch)
2025-10-27 16:36 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 41112: Space is missing in report preview (2.90 KB, patch)
2025-10-28 13:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 41112: Space is missing in report preview (2.95 KB, patch)
2025-10-28 17:46 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2025-10-27 16:32:10 UTC
A space is missing after the </i> in reports/guided_reports_start.tt
Comment 1 Baptiste Wojtkowski (bwoj) 2025-10-27 16:34:43 UTC Comment hidden (obsolete)
Comment 2 Baptiste Wojtkowski (bwoj) 2025-10-27 16:36:13 UTC
Created attachment 188483 [details] [review]
Bug 41112: Space is missing in report preview

This patch puts back a missing space between "Delete" and the fa
thrashcan. It is atm the lonely button without this space in the modal

No test plan needed. The change is too trivial.
Just check that lines before in the code have the desired space. The
missing space creates a weird sensation while looking at the window.
Comment 3 David Nind 2025-10-28 13:22:54 UTC
Created attachment 188509 [details] [review]
Bug 41112: Space is missing in report preview

This patch puts back a missing space between "Delete" and the fa
thrashcan. It is atm the lonely button without this space in the modal

No test plan needed. The change is too trivial.
Just check that lines before in the code have the desired space. The
missing space creates a weird sensation while looking at the window.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-10-28 13:27:15 UTC
Testing notes (using KTD):

1. In the reports module, create a report and save it.
2. From the saved reports list, select 'Preview SQL' from the dropdown list of actions.
3. Note that there is no space between the trash can icon and Delete.
4. Apply the patch.
5. Refresh the saved reports page.
6. Repeat step 2.
7. Note that there is now a space between the trash can icon and Delete, consistent with the other action buttons.
Comment 5 Brendan Lawlor 2025-10-28 17:46:19 UTC
Created attachment 188522 [details] [review]
Bug 41112: Space is missing in report preview

This patch puts back a missing space between "Delete" and the fa
thrashcan. It is atm the lonely button without this space in the modal

No test plan needed. The change is too trivial.
Just check that lines before in the code have the desired space. The
missing space creates a weird sensation while looking at the window.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 6 Brendan Lawlor 2025-10-28 17:47:06 UTC
Trivial fix. Passing QA.
Comment 7 Lucas Gass (lukeg) 2025-10-31 21:32:42 UTC
Nice work everyone!

Pushed to main for 25.11