| Summary: | Spinner/loader does not disappear when a renewal fails with AllowRenewalOnHoldOverride set to dont allow | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | Pushed to oldstable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.06,24.11.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 41149: Replace replaceWith() with empty() and append()
Bug 41149: Replace replaceWith() with empty() and append() Bug 41149: Replace replaceWith() with empty() and append() |
||
|
Description
Lucas Gass (lukeg)
2025-10-30 20:14:53 UTC
Created attachment 188706 [details] [review] Bug 41149: Replace replaceWith() with empty() and append() Created attachment 188824 [details] [review] Bug 41149: Replace replaceWith() with empty() and append() To test: 1. Set AllowRenewalOnHoldOverride to 'Dont allow' 2. Set OverduesBlockRenewing to "block renewing" 3. Checkout an item and mark it as overdue. 4. Place a hold on that item to someone else 5. Now go look at the issues table for that patron/item 6. Check "Override renewal restrictions:" 7. Now a checkbox should appear in the "Renew" column, check it. 8. Click "Renew selected items" 9. After the "Renew failed: on hold" appears the spinning icon should disappear. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 189685 [details] [review] Bug 41149: Replace replaceWith() with empty() and append() To test: 1. Set AllowRenewalOnHoldOverride to 'Dont allow' 2. Set OverduesBlockRenewing to "block renewing" 3. Checkout an item and mark it as overdue. 4. Place a hold on that item to someone else 5. Now go look at the issues table for that patron/item 6. Check "Override renewal restrictions:" 7. Now a checkbox should appear in the "Renew" column, check it. 8. Click "Renew selected items" 9. After the "Renew failed: on hold" appears the spinning icon should disappear. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.11 |