To recreate: 1. Set AllowRenewalOnHoldOverride to 'Dont allow' 2. Set OverduesBlockRenewing to "block renewing" 3. Checkout an item and mark it as overdue. 4. Place a hold on that item to someone else 5. Now go look at the issues table for that patron/item 6. Check "Override renewal restrictions:" 7. Now a checkbox should appear in the "Renew" column, check it. 8. Click "Renew selected items" 9. You should correctly see "Renew failed: on hold" with a spinning icon that never goes away. The fact that the spinning icon doesn't go away is confusing to staff. It makes it seem like something is still happening or something is wrong, neither are the case.
Created attachment 188706 [details] [review] Bug 41149: Replace replaceWith() with empty() and append()
Created attachment 188824 [details] [review] Bug 41149: Replace replaceWith() with empty() and append() To test: 1. Set AllowRenewalOnHoldOverride to 'Dont allow' 2. Set OverduesBlockRenewing to "block renewing" 3. Checkout an item and mark it as overdue. 4. Place a hold on that item to someone else 5. Now go look at the issues table for that patron/item 6. Check "Override renewal restrictions:" 7. Now a checkbox should appear in the "Renew" column, check it. 8. Click "Renew selected items" 9. After the "Renew failed: on hold" appears the spinning icon should disappear. Signed-off-by: Owen Leonard <oleonard@myacpl.org>