Bug 41149 - Spinner/loader does not disappear when a renewal fails with AllowRenewalOnHoldOverride set to dont allow
Summary: Spinner/loader does not disappear when a renewal fails with AllowRenewalOnHol...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-30 20:14 UTC by Lucas Gass (lukeg)
Modified: 2025-12-04 13:34 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.06,24.11.11
Circulation function:


Attachments
Bug 41149: Replace replaceWith() with empty() and append() (987 bytes, patch)
2025-10-30 20:26 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 41149: Replace replaceWith() with empty() and append() (1.48 KB, patch)
2025-10-31 12:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41149: Replace replaceWith() with empty() and append() (1.55 KB, patch)
2025-11-18 19:23 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-10-30 20:14:53 UTC
To recreate:

1. Set AllowRenewalOnHoldOverride to 'Dont allow'
2. Set  OverduesBlockRenewing to "block renewing"
3. Checkout an item and mark it as overdue.
4. Place a hold on that item to someone else 
5. Now go look at the issues table for that patron/item
6. Check "Override renewal restrictions:"
7. Now a checkbox should appear in the "Renew" column, check it.
8. Click "Renew selected items"
9. You should correctly see "Renew failed: on hold" with a spinning icon that never goes away. 

The fact that the spinning icon doesn't go away is confusing to staff. It makes it seem like something is still happening or something is wrong, neither are the case.
Comment 1 Lucas Gass (lukeg) 2025-10-30 20:26:58 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2025-10-31 12:56:30 UTC
Created attachment 188824 [details] [review]
Bug 41149: Replace replaceWith() with empty() and append()

To test:

1. Set AllowRenewalOnHoldOverride to 'Dont allow'
2. Set  OverduesBlockRenewing to "block renewing"
3. Checkout an item and mark it as overdue.
4. Place a hold on that item to someone else
5. Now go look at the issues table for that patron/item
6. Check "Override renewal restrictions:"
7. Now a checkbox should appear in the "Renew" column, check it.
8. Click "Renew selected items"
9. After the "Renew failed: on hold" appears the spinning icon should
   disappear.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2025-11-18 19:23:36 UTC
Created attachment 189685 [details] [review]
Bug 41149: Replace replaceWith() with empty() and append()

To test:

1. Set AllowRenewalOnHoldOverride to 'Dont allow'
2. Set  OverduesBlockRenewing to "block renewing"
3. Checkout an item and mark it as overdue.
4. Place a hold on that item to someone else
5. Now go look at the issues table for that patron/item
6. Check "Override renewal restrictions:"
7. Now a checkbox should appear in the "Renew" column, check it.
8. Click "Renew selected items"
9. After the "Renew failed: on hold" appears the spinning icon should
   disappear.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 4 Lucas Gass (lukeg) 2025-11-21 15:43:16 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-12-01 14:55:53 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 6 Fridolin Somers 2025-12-04 13:34:01 UTC
Pushed to 24.11.x for 24.11.11