| Summary: | Definite article in some labels confuses screen readers | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jake Deery <jake.deery> |
| Component: | Accessibility | Assignee: | Jake Deery <jake.deery> |
| Status: | Needs documenting --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, martin.renvoize, matt.blenkinsop, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 41201: Removed definite article from hold and cart
Bug 41201: Removed definite article from hold and cart Bug 41201: Removed definite article from hold and cart |
||
Created attachment 189150 [details] [review] Bug 41201: Removed definite article from hold and cart This patch removes the definite article from some labels, so that their visual and hidden labels are in sync. == TO TEST == a) (optionally) read the patch code to understand what locations have change b) inspect the code on the results and details pages c) note that some visual and hidden labels differ *) specifically, the add to cart and place hold labels == APPLY PATCH == d) repeat step b) e) notice now that the visual and hidden labels match == SIGN OFF == Created attachment 189180 [details] [review] Bug 41201: Removed definite article from hold and cart This patch removes the definite article from some labels, so that their visual and hidden labels are in sync. == TO TEST == a) (optionally) read the patch code to understand what locations have change b) inspect the code on the results and details pages c) note that some visual and hidden labels differ *) specifically, the add to cart and place hold labels == APPLY PATCH == d) repeat step b) e) notice now that the visual and hidden labels match == SIGN OFF == Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 189251 [details] [review] Bug 41201: Removed definite article from hold and cart This patch removes the definite article from some labels, so that their visual and hidden labels are in sync. == TO TEST == a) (optionally) read the patch code to understand what locations have change b) inspect the code on the results and details pages c) note that some visual and hidden labels differ *) specifically, the add to cart and place hold labels == APPLY PATCH == d) repeat step b) e) notice now that the visual and hidden labels match == SIGN OFF == Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Hard to apply on 24.11.x because of code tidy Also would generate some translation work. Since this is minor I skip for 24.11.x LTS |
Some labels on the OPAC include a definite article ("place a hold on xxxx"). These definite articles have thrown some user's screen readers, as the hidden label does not match the visible label ("place hold").