Bug 41201

Summary: Definite article in some labels confuses screen readers
Product: Koha Reporter: Jake Deery <jake.deery>
Component: AccessibilityAssignee: Jake Deery <jake.deery>
Status: Passed QA --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: m.de.rooy, martin.renvoize, matt.blenkinsop, oleonard
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 41201: Removed definite article from hold and cart
Bug 41201: Removed definite article from hold and cart
Bug 41201: Removed definite article from hold and cart

Description Jake Deery 2025-11-06 09:13:56 UTC
Some labels on the OPAC include a definite article ("place a hold on xxxx"). These definite articles have thrown some user's screen readers, as the hidden label does not match the visible label ("place hold").
Comment 1 Jake Deery 2025-11-06 09:30:30 UTC
Created attachment 189150 [details] [review]
Bug 41201: Removed definite article from hold and cart

This patch removes the definite article from some labels, so that their
visual and hidden labels are in sync.

== TO TEST ==
a)  (optionally) read the patch code to understand what locations have change
b)  inspect the code on the results and details pages
c)  note that some visual and hidden labels differ
    *)  specifically, the add to cart and place hold labels
== APPLY PATCH ==
d)  repeat step b)
e)  notice now that the visual and hidden labels match
== SIGN OFF ==
Comment 2 Owen Leonard 2025-11-06 14:41:55 UTC
Created attachment 189180 [details] [review]
Bug 41201: Removed definite article from hold and cart

This patch removes the definite article from some labels, so that their
visual and hidden labels are in sync.

== TO TEST ==
a)  (optionally) read the patch code to understand what locations have change
b)  inspect the code on the results and details pages
c)  note that some visual and hidden labels differ
    *)  specifically, the add to cart and place hold labels
== APPLY PATCH ==
d)  repeat step b)
e)  notice now that the visual and hidden labels match
== SIGN OFF ==

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2025-11-07 07:57:07 UTC
Created attachment 189251 [details] [review]
Bug 41201: Removed definite article from hold and cart

This patch removes the definite article from some labels, so that their
visual and hidden labels are in sync.

== TO TEST ==
a)  (optionally) read the patch code to understand what locations have change
b)  inspect the code on the results and details pages
c)  note that some visual and hidden labels differ
    *)  specifically, the add to cart and place hold labels
== APPLY PATCH ==
d)  repeat step b)
e)  notice now that the visual and hidden labels match
== SIGN OFF ==

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>