Bug 41217

Summary: Missing class on body tag for reserve/hold-group.tt
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Staff interfaceAssignee: Jonathan Druart <jonathan.druart>
Status: Needs documenting --- QA Contact: David Cook <dcook>
Severity: minor    
Priority: P5 - low CC: dcook, fridolin.somers, gmcharlt, Laura.escamilla
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.07
Circulation function:
Bug Depends on: 15516    
Bug Blocks: 41216    
Attachments: Bug 41217: Add missing class on body tag for reserve/hold-group.tt
Bug 41217: Add missing class on body tag for reserve/hold-group.tt
Bug 41217: Add missing class on body tag for reserve/hold-group.tt
Bug 41217: Add missing class on body tag for reserve/hold-group.tt

Description Jonathan Druart 2025-11-07 12:15:54 UTC

    
Comment 1 Jonathan Druart 2025-11-07 12:18:42 UTC
Created attachment 189293 [details] [review]
Bug 41217: Add missing class on body tag for reserve/hold-group.tt

It is a requirement to have id and class on the body tag. We had a test
that was incorrectly removed (see bug 41216)

Test plan:
Confirm that now reserve/request.pl and reserve/hold-group.pl have the
class "reserve" on the body tag.
Note that reserve/request.pl previously had "catalog", that feels wrong,
please let me know if you disagree with "reserve"
Comment 2 Jonathan Druart 2025-11-07 12:58:27 UTC
Created attachment 189315 [details] [review]
Bug 41217: Add missing class on body tag for reserve/hold-group.tt

It is a requirement to have id and class on the body tag. We had a test
that was incorrectly removed (see bug 41216)

Test plan:
Confirm that now reserve/request.pl and reserve/hold-group.pl have the
class "reserve" on the body tag.
Note that reserve/request.pl previously had "catalog", that feels wrong,
please let me know if you disagree with "reserve"
Comment 3 Laura Escamilla 2025-11-07 14:27:53 UTC
Created attachment 189332 [details] [review]
Bug 41217: Add missing class on body tag for reserve/hold-group.tt

It is a requirement to have id and class on the body tag. We had a test
that was incorrectly removed (see bug 41216)

Test plan:
Confirm that now reserve/request.pl and reserve/hold-group.pl have the
class "reserve" on the body tag.
Note that reserve/request.pl previously had "catalog", that feels wrong,
please let me know if you disagree with "reserve"

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 David Cook 2025-11-11 03:41:47 UTC
Created attachment 189464 [details] [review]
Bug 41217: Add missing class on body tag for reserve/hold-group.tt

It is a requirement to have id and class on the body tag. We had a test
that was incorrectly removed (see bug 41216)

Test plan:
Confirm that now reserve/request.pl and reserve/hold-group.pl have the
class "reserve" on the body tag.
Note that reserve/request.pl previously had "catalog", that feels wrong,
please let me know if you disagree with "reserve"

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 5 Lucas Gass (lukeg) 2025-11-17 22:17:23 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Laura Escamilla 2026-01-05 18:47:05 UTC
This change has been backported to the 25.05.x branch for its accessibility features. Thank you!
Comment 7 Fridolin Somers 2026-01-09 08:51:06 UTC
(In reply to Laura Escamilla from comment #6)
> This change has been backported to the 25.05.x branch for its accessibility
> features. Thank you!

This depends on Bug 15516 that is not in 25.05.x
So in my opinion this sould not be backported.
The body class may be used in custom CSS/JS.