| Summary: | ILL "List requests"/"Refresh" wording doesn't work | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
| Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
| Status: | Pushed to main --- | QA Contact: | Lisette Scheer <lisette> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | lisette, lucas, pedro.amorim, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 41257: Fix wording condition check
Bug 41257: Remove 'btn-sm' CSS class Bug 41257: Remove 'btn-sm' CSS class Bug 41257: Fix wording condition check Bug 41257: Fix wording condition check Bug 41257: Remove 'btn-sm' CSS class |
||
|
Description
Pedro Amorim
2025-11-17 14:42:11 UTC
Created attachment 189631 [details] [review] Bug 41257: Fix wording condition check To reproduce: 1) Enable ILLModule 2) Visit ILL requests: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 3) Where 'List requests' show, it should show 'Refresh'. 4) Apply patches, refresh, notice it now shows 'Refresh'. Created attachment 189632 [details] [review] Bug 41257: Remove 'btn-sm' CSS class It may have made sense in the past but I don't think it does anymore. It adds an odd bottom spacing to the button Created attachment 189643 [details] [review] Bug 41257: Remove 'btn-sm' CSS class It may have made sense in the past but I don't think it does anymore. It adds an odd bottom spacing to the button Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Created attachment 189644 [details] [review] Bug 41257: Fix wording condition check To reproduce: 1) Enable ILLModule 2) Visit ILL requests: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 3) Where 'List requests' show, it should show 'Refresh'. 4) Apply patches, refresh, notice it now shows 'Refresh'. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Small enough that I'm going to pass qa. Created attachment 189646 [details] [review] Bug 41257: Fix wording condition check To reproduce: 1) Enable ILLModule 2) Visit ILL requests: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 3) Where 'List requests' show, it should show 'Refresh'. 4) Apply patches, refresh, notice it now shows 'Refresh'. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Created attachment 189647 [details] [review] Bug 41257: Remove 'btn-sm' CSS class It may have made sense in the past but I don't think it does anymore. It adds an odd bottom spacing to the button Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Re uploaded the patches in the correct order. Nice work everyone! Pushed to main for 25.11 |